Cleanup broken root_key_id for outputs, so all of them was in correct account.

Author: bay

impls/src/lifecycle/default.rs

@@ -20,15 +20,17 @@ use crate::config::{
 	MWC_WALLET_DIR,
 };
 use crate::core::global;
-use crate::keychain::Keychain;
+use crate::keychain::{ChildNumber, Keychain};
 use crate::libwallet::swap::ethereum::generate_ethereum_wallet;
 use crate::libwallet::{Error, NodeClient, WalletBackend, WalletLCProvider};
 use crate::lifecycle::seed::WalletSeed;
 use crate::util::secp::key::SecretKey;
 use crate::util::ZeroingString;
 use crate::LMDBBackend;
-use mwc_wallet_libwallet::types::{FLAG_CONTEXT_CLEARED, FLAG_NEW_WALLET};
-use mwc_wallet_libwallet::{Context, TxLogEntryType};
+use mwc_wallet_libwallet::types::{
+	FLAG_CONTEXT_CLEARED, FLAG_NEW_WALLET, FLAG_OUTPUTS_ROOT_KEY_ID_CORRECTION,
+};
+use mwc_wallet_libwallet::{Context, OutputData, TxLogEntryType};
 use mwc_wallet_util::mwc_util::logger::LoggingConfig;
 use std::collections::HashMap;
 use std::fs;
@@ -302,6 +304,7 @@ where
 		let mask = wallet.set_keychain(Box::new(keychain), create_mask, use_test_rng)?;
 
 		{
+			// Cleaning dangling contexts.
 			let mut batch = wallet.batch(mask.as_ref())?;
 			if !batch.load_flag(FLAG_CONTEXT_CLEARED, false)? {
 				let mut contexts: HashMap<Uuid, Context> = batch
@@ -333,6 +336,31 @@ where
 			batch.commit()?;
 		}
 
+		{
+			// Cleaning broken root_key_id from outputs. It is old bug that was fixed on Sept 2024, but the data was never fixed.
+			let mut batch = wallet.batch(mask.as_ref())?;
+			if !batch.load_flag(FLAG_OUTPUTS_ROOT_KEY_ID_CORRECTION, false)? {
+				let broken_outputs: Vec<OutputData> = batch
+					.iter()
+					.filter(|o| {
+						// We need to fix last element of path if it is not 0
+						let path = o.root_key_id.to_path();
+						let last_id = u32::from(path.path[3]);
+						last_id != 0
+					})
+					.collect();
+
+				for mut out in broken_outputs {
+					let mut path = out.root_key_id.to_path();
+					path.path[3] = ChildNumber::from(0);
+					out.root_key_id = path.to_identifier();
+					batch.save(out)?;
+				}
+				batch.save_flag(FLAG_OUTPUTS_ROOT_KEY_ID_CORRECTION)?;
+			}
+			batch.commit()?;
+		}
+
 		self.backend = Some(Box::new(wallet));
 		Ok(mask)
 	}

libwallet/src/types.rs

@@ -277,6 +277,8 @@ where
 pub const FLAG_NEW_WALLET: u64 = 1;
 /// Need to clean private context on the first wallet run
 pub const FLAG_CONTEXT_CLEARED: u64 = 2;
+/// Need to correct outputs root_key_id values to recover from prev bug
+pub const FLAG_OUTPUTS_ROOT_KEY_ID_CORRECTION: u64 = 3;
 
 /// Batch trait to update the output data backend atomically. Trying to use a
 /// batch after commit MAY result in a panic. Due to this being a trait, the