Skip to content

Fix zeep for httpx after 0.28.0 #1468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix zeep for httpx after 0.28.0 #1468

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/zeep/transports.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,13 +185,13 @@ def __init__(
self.cache = cache
self.wsdl_client = wsdl_client or httpx.Client(
verify=verify_ssl,
proxies=proxy,
timeout=timeout,
**({"proxies": proxy} if httpx.__version__ < "0.28.0" else {"proxy": proxy}),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This version check is incorrect:

>>> "0.3.0" <= "0.28.0"
False

0.3.0 being older than 0.28.0 should be using proxy.

See #1447

)
self.client = client or httpx.AsyncClient(
verify=verify_ssl,
proxies=proxy,
timeout=operation_timeout,
**({"proxies": proxy} if httpx.__version__ < "0.28.0" else {"proxy": proxy}),
)
self.logger = logging.getLogger(__name__)

Expand Down