Updated list to remove template

djthorpe · djthorpe · commit 0e775484dd9b · 2021-04-22T17:38:42.000+02:00
diff --git a/js/list.js b/js/list.js
@@ -42,12 +42,12 @@ export default class List extends View {
       throw new Error(`Invalid List template with name ${classTemplate}`);
     }
 
-    // Hide the template
-    template.classList.add('d-none');
-
     // Create a prototype row
     this.$prototype = template.cloneNode(true);
     this.$prototype.classList.remove(this.$className);
+
+    // Remove node from parent
+    node.removeChild(template);
   }
 
   /**
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@djthorpe/js-framework",
-  "version": "0.0.38",
+  "version": "0.0.39",
   "description": "Javascript Framework",
   "main": "dist/index.js",
   "scripts": {

Original file line number	Diff line number	Diff line change
`@@ -42,12 +42,12 @@ export default class List extends View {`
`42`	`42`	throw new Error(`Invalid List template with name ${classTemplate}`);
`43`	`43`	`}`
`44`	`44`
`45`		`- // Hide the template`
`46`		`- template.classList.add('d-none');`
`47`		`-`
`48`	`45`	`// Create a prototype row`
`49`	`46`	`this.$prototype = template.cloneNode(true);`
`50`	`47`	`this.$prototype.classList.remove(this.$className);`
	`48`	`+`
	`49`	`+ // Remove node from parent`
	`50`	`+ node.removeChild(template);`
`51`	`51`	`}`
`52`	`52`
`53`	`53`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@djthorpe/js-framework",`
`3`		`- "version": "0.0.38",`
	`3`	`+ "version": "0.0.39",`
`4`	`4`	`"description": "Javascript Framework",`
`5`	`5`	`"main": "dist/index.js",`
`6`	`6`	`"scripts": {`