added bigbluebutton plugin #1161
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumpfralle
reviewed
Jan 26, 2021
| try: | ||
| tree = ElementTree.fromstring(responsedata) | ||
| except HTTPError as e: | ||
| print('There was an error with the recieved data from bbb api.') |
There was a problem hiding this comment.
Here you could add file=sys.stderr. Otherwise munin would try to parse the mess.
There was a problem hiding this comment.
You mean writing to standard error instead of printing? Sounds good to me.
|
Stale pull request message |
|
What do you think? |
|
@zettrik: Can you look @sumpfralle comments? What do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new plugin to monitor the usage (user, meeting rooms ...) of a bigbluebutton server.