[ButtonBase] The LinkComponent prop does not take effect when set in MenuItem

[aress31]

I already opened a ticket about this specific bug but it was quickly discarded without any serious investigation, see #28251.

The bug is that MuiListItemButton and MuiMenuItem (subclasses of MuiButtonBase) are not inheriting the LinkComponent prop of MuiButtonBase and this despite the doc clearly stating that both of these components should inherit from MuiButtonBse, see:

Props of the ButtonBase component are also available.

Could you kindly investigate this issue?

CodeSandbox: https://codesandbox.io/s/mui-28251-28335-p7krh

[mnajdova]

The props are forwarded to the ButtonBase component. However, the logic in the ButtonBase component is the following: it considers the LinkComponent property, only if the component prop is not set and there is a href on the component. The MenuItem is already setting the component prop to 'li'. So, in order to fix this, you need to use the component prop directly. See https://codesandbox.io/s/mui-28251-28335-forked-wdq76?file=/src/App.js (something is failing after the component is set, but I will leave this to you :))

I've seen several issues around the LinkComponent and when this prop is being considered, in my opinion we should maybe drop it in v6 in favor of the components and componentsProps API.

[aress31]

Thanks for the detailed information, it is indeed confusing.

[NathanC]

FYI for anyone having this issue, the workaround of using component currently doesn't work because the component prop is missing. See #33710