Skip to content

The padding for IconButton and ListItem are absent for @material-ui/core 5.0.0-alpha.21 #24203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks done
andrew-hwahin opened this issue Dec 31, 2020 · 6 comments
Closed
2 tasks done
Labels
duplicate This issue or pull request already exists

Comments

@andrew-hwahin
Copy link

andrew-hwahin commented Dec 31, 2020

  • The issue is present in the latest release.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

image

Expected Behavior 🤔

image

Steps to Reproduce 🕹

Steps:

Upgrade @material-ui/core from 5.0.0-alpha.20 to 5.0.0-alpha.21

Context 🔦

Your Environment 🌎

`npx @material-ui/envinfo`

image

@andrew-hwahin andrew-hwahin added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Dec 31, 2020
@mbrookes mbrookes added status: waiting for author Issue with insufficient information and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Dec 31, 2020
@mbrookes
Copy link
Member

Please provide a code-sandbox reproducing the issue, thanks.

@xs9627
Copy link
Contributor

xs9627 commented Dec 31, 2020

Got the same problem,
It seems emotion style loaded in the wrong order and override the jss style,
image
Try yarn start on my project,
https://github.com/xs9627/feedpop/tree/next_21

@mnajdova
Copy link
Member

Duplicate of #24186

You need to use <StylesProvider injectFirst> from @material-ui/core in order for the emotion styles to be injected first in the head. See https://next.material-ui.com/guides/interoperability/#css-injection-order for more info.

@oliviertassinari oliviertassinari added duplicate This issue or pull request already exists and removed status: waiting for author Issue with insufficient information labels Dec 31, 2020
@oliviertassinari
Copy link
Member

Duplicate of #24109

@oliviertassinari oliviertassinari marked this as a duplicate of #24109 Dec 31, 2020
@andrew-hwahin
Copy link
Author

andrew-hwahin commented Jan 2, 2021

Duplicate of #24186

You need to use <StylesProvider injectFirst> from @material-ui/core in order for the emotion styles to be injected first in the head. See https://next.material-ui.com/guides/interoperability/#css-injection-order for more info.

After I add <StylesProvider injectFirst> the result is still the same

I'm using import { makeStyles } from '@material-ui/core/styles' to style my component.

@mnajdova
Copy link
Member

mnajdova commented Jan 2, 2021

It should work. Make sure the import to the StylesProvider is correct. If you provide codesandbox I can take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

5 participants