in TablePagination 'actions' classes key is missing

[gadkadosh]

actions classes key is documented, yet seems not to be implemented in the code.
I looked quickly in TablePagination and TablePaginationActions.

[oliviertassinari]

@gadkadosh It's a good point. I think that we should move the TablePaginationActions's styles to the TablePagination component and inject a classes property to the action child.
https://github.com/mui-org/material-ui/blob/bbbc7a57a26673f9304275f2444a445b56ac4f71/src/Table/TablePaginationActions.js#L9-L13

[lukePeavey]

Is it ok if I work on this?

[oliviertassinari]

@lukePeavey Sorry for the delay. Ideally, I wanted to clear the render prop API story before taking care of this issue: #10476. It can change the way we handle it. But after more thought, I think that we can move forward here. So what do you think of moving the TablePaginationActions.js styles into TablePagination.js and having it providing a "filtered" classes property?

[t49tran]

Have anyone started working on this issue yet ? If not I can start a PR.

[lukePeavey]

@t49tran yeah, I'm currently working on a PR for this.

[lukePeavey]

@oliviertassinari Sorry it took me so long to respond!

I didn't initially notice that that you had labeled this as post-v1. If you would rather just wait and address this after the render prop api question is resolved, thats totally fine with me.

I think that we should move the TablePaginationActions's styles to the TablePagination component and inject a classes property to the action child.

I think this makes sense, at least as a short term solution. If you want to go ahead with this, i've made the changes and can submit a PR.

[oliviertassinari]

@lukePeavey It's label post-v1 as it's not required to cut v1 out (the deadline is in one month). It's a simple change, so if you want to work on it, it's always great :).

[lukePeavey]

Oh ok