-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RTCMultiConnection v3 Video Scalable Broadcast #88
Comments
OK. I'll add a demo in the next commit. However #87 may take time (a week or two) to be fixed, because current scalable-broadcast architecture fails if any of the middle node leaves. |
I rewrited Scalable-Broadcast.js architecture a little and just tested https://rtcmulticonnection.herokuapp.com/demos/Video-Scalable-Broadcast.html with RTCMultiConnection v3. Waiting for your next commit with RTCMultiConnection v3 scalable video broadcasting demo 👍 |
@muaz-khan Can you please provide v3 demo before you start to fix #87? |
Here is a LIVE demo: |
@muaz-khan Thank you very much!
Are you planning to fix these things yourself? |
@muaz-khan waiting for your answers ℹ️ |
We need to override We can use BTW, yep, I'll fix #87 and similar issues soon, in 1-2 days. I'll improve |
@muaz-khan Cool, then it will be ready on monday. I really appreciate your contribution! 👍 Can you please make a sample / demo, where any recorder is used to play recorded stream until new broadcaster joins?
it gives me black screen instead of video from the next broadcaster (how can I replace old video with the new one?) |
Recording support has been added in the recent commit: d79b5ff Now Also,
Chrome stable will merely record video tracks. Chrome Canary with |
@muaz-khan Thank you very much! 👍 I just tested your recent commit on the latest Chrome (with enabled experimental web platform feature flags) and Firefox. It seems a good idea to change URL for existing video element. On Chrome (version: 48.0.2564.103 m):
On Firefox (version: 44.0):
P.S. Can you please fix these bugs? And when can we expect full working example / demo where:
|
@muaz-khan I'm looking forward to hear answers to my previous comment from you soon 👂 You are our only hope ❗ 😃 |
1) “maxRelayLimitPerNode” now works fine. So whatever limit HTML sets, it works. 2) If any of the node from tree leaves, all nested nodes AUTO tries to rejoin broadcast. 3) If broadcast initiator leaves, all receivers are informed and page is reloaded to clear everything. By default demo sets max-relay-limit to 1; i.e. each relayer merely relays to single another peer. This limit can be easily be changed by setting single number in the HTML file. Known issues: Sometimes it hangs the browser. Also “Maximum call stack size exceeded” on server.
@muaz-khan Is there any way to turn in real time WebRTC into something like a url to HLS? |
@muaz-khan Hi! You did a great job here. Thank you! 👍
Can you please fix these bugs? |
Also in browser console now there is an error: To repeat it, just open https://rtcmulticonnection.herokuapp.com/demos/Scalable-Broadcast.html and start a video stream |
@muaz-khan please let me know what do you think about both of my previous comments |
The image you attached in this commit is referring All these issues are in my todo list however I'll be able to try fixing them at next Wednesday. |
Ok, waiting for your next commit 😃 |
I just noticed another bug:
|
Hey @muaz-khan! Did you fix something? |
1) Firefox can NOT record remote-VIDEO-stream 2) Firefox can NOT removeStream 3) Firefox can NOT use replaceTrack for remoteMediaStream So if any of the middle peer leaves, Firefox is no where. The only solution for Firefox in such situation is “rejoin”.
Hello Muaz, |
@muaz-khan please provide example with Video Scalable Broadcast where RTCMultiConnection v3 is used.
Currently there is only https://rtcmulticonnection.herokuapp.com/demos/Video-Scalable-Broadcast.html example where RTCMultiConnection v2.2.2 is used.
This morning I tried locally the same example with RTCMultiConnection v3 and watchers can't see the video stream. Only initiator can see his own video.
The text was updated successfully, but these errors were encountered: