Skip to content

Commit d23754a

Browse files
committed
make boot.sh run as process 0
we want boot.sh to correctly receive and forwards signals. this commit removes the double indirection (`CMD` in non array form will already execute the command in a sh subshell and we wrapped our script in another one).
1 parent 6f49345 commit d23754a

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ RUN chmod +x /usr/src/app/build-production.sh
2424

2525
EXPOSE ${PORT}
2626

27-
CMD sh boot.sh
27+
CMD ["/usr/src/app/boot.sh"]
2828

2929
# This stuff only runs when building an image from the template
3030
ONBUILD RUN rm -Rf /app/scripts

boot.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
#!/usr/bin/env bash
12
if [ "$NODE_ENV" == "development" ]
23
then
34
# Run live-reload development

0 commit comments

Comments
 (0)