Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unusable overlay windows when using small android display size setting #1625

Open
klaviartur opened this issue Jan 15, 2025 · 3 comments
Open

Comments

@klaviartur
Copy link

Screenshot_20250115-222916_Meine Ausgaben

After setting Display Size setting in Android system settings to small, myexpenses no longer opens new transaction (and other dialogs) dialog in full screen, but rather in an overlay window in the center of the screen.
I guess this has to do with automatic layout change for tablets or something.

In the end it makes everything extremely cramped in that oerlay window and unusable (at least for me). So myexpenses forced me to reset display size to default.

I think there should be at least a manual override of this behaviour somewhere in the expert settings to force full screen dialogs.
Or a more advanced automatic detection of sensible dialog sizes.

@mtotschnig
Copy link
Owner

@klaviartur Thanks for the report. Currently the app uses a component that decides based on a size property of the screen configuration that Android OS provides. According to this property, in your configuration, the screen is large. This is kind of an edge case, and unfortunately using this component, it is not possible to change the breakpoint which is 480x640 dp. So unfortunately, this cannot be fixed easily, and might only be addressed with a complete refactoring of the edit screen.

@klaviartur
Copy link
Author

Thanks for the quick reply!

Is this component only determining the size of the dialog or actually drawing it?
What I'm getting at: is deactivating /circumventing this component entirely to force full screen possible?

This would have to be controlled by a switch somewhere in expert settings, of course, to not interfere with regular tablet users.

@mtotschnig
Copy link
Owner

@klaviartur The component is actually a Theme, and allowing user to select between themes is theoretically possible (We had done this for dark and light theme before Android(x) introduced support for it, but bringing it back is unfortunately not realistic at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants