Creating vnet.More vnet refactoring. Changing documentation

Author: Federico Arambarri

cluster-stamp.bicep

@@ -74,6 +74,10 @@ param jumpBoxImageResourceId string
 @minLength(100)
 param jumpBoxCloudInitAsBase64 string
 
+@description('Subnet resource Id for the AKS jumpbox subnet')
+@minLength(79)
+param aksJumpboxSubnetResourceId string
+
 /*** VARIABLES ***/
 
 var kubernetesVersion = '1.23.12'
@@ -123,6 +127,24 @@ var pdEnforceImageSourceId = tenantResourceId('Microsoft.Authorization/policyDef
 
 /*** EXISTING RESOURCE GROUP RESOURCES ***/
 
+@description('The resource group name containing virtual network in which Jumpbox will be dropped.')
+resource rgJumpBoxVirutalNetwork 'Microsoft.Resources/resourceGroups@2021-04-01' existing = {
+  scope: subscription()
+  name: split(aksJumpboxSubnetResourceId, '/')[4]
+}
+
+@description('Jumpbox Spoke Virtual Network')
+resource aksJumpBoxSpokeVnet 'Microsoft.Network/virtualNetworks@2022-01-01' existing = {
+  scope: rgJumpBoxVirutalNetwork
+  name: split(aksJumpboxSubnetResourceId, '/')[8]
+}
+
+@description('Jumpbox subnet')
+resource aksJumpboxSubnet 'Microsoft.Network/virtualNetworks/subnets@2022-01-01' existing = {
+  parent: aksJumpBoxSpokeVnet
+  name: last(split(aksJumpboxSubnetResourceId, '/'))
+}
+
 @description('Spoke resource group')
 resource spokeResourceGroup 'Microsoft.Resources/resourceGroups@2021-04-01' existing = {
   scope: subscription()
@@ -144,11 +166,6 @@ resource vnetSpoke 'Microsoft.Network/virtualNetworks@2022-01-01' existing = {
     name: 'snet-privatelinkendpoints'
   }
 
-  // spoke virtual network's subnet for managment ops
-  resource snetManagmentOps 'subnets' existing = {
-    name: 'snet-management-ops'
-  }
-
   // spoke virtual network's subnet for managment acr agent pools
   resource snetManagmentCrAgents 'subnets' existing = {
     name: 'snet-management-acragents'
@@ -817,7 +834,7 @@ resource vmssJumpboxes 'Microsoft.Compute/virtualMachineScaleSets@2020-12-01' =
                     privateIPAddressVersion: 'IPv4'
                     publicIPAddressConfiguration: null
                     subnet: {
-                      id: vnetSpoke::snetManagmentOps.id
+                      id: aksJumpboxSubnet.id
                     }
                   }
                 }

docs/deploy/06-aks-jumpboximage.md

@@ -34,7 +34,7 @@ You are going to be using Azure Image Builder to generate a Kubernetes-specific
 
 ### Deploy the spoke
 
-1. Create the AKS jump box image builder network spoke.
+1. Create the AKS jump box image builder and JumpBox network spoke.
 
    ```bash
    RESOURCEID_VNET_HUB=$(az deployment group show -g rg-enterprise-networking-hubs -n hub-region.v0 --query properties.outputs.hubVnetId.value -o tsv)
@@ -52,8 +52,10 @@ You are going to be using Azure Image Builder to generate a Kubernetes-specific
    ```bash
    RESOURCEID_SUBNET_AIB=$(az deployment group show -g rg-enterprise-networking-spokes -n spoke-BU0001A0005-00 --query properties.outputs.imageBuilderSubnetResourceId.value -o tsv)
 
+   RESOURCEID_SUBNET_JUMPBOX=$(az deployment group show -g rg-enterprise-networking-spokes -n spoke-BU0001A0005-00 --query properties.outputs.jumpboxSubnetResourceId.value -o tsv)
+
    # [This takes about five minutes to run.]
-   az deployment group create -g rg-enterprise-networking-hubs -f networking/hub-region.v1.bicep -p location=eastus2 aksImageBuilderSubnetResourceId="${RESOURCEID_SUBNET_AIB}"
+   az deployment group create -g rg-enterprise-networking-hubs -f networking/hub-region.v1.bicep -p location=eastus2 aksImageBuilderSubnetResourceId="${RESOURCEID_SUBNET_AIB}" aksJumpboxSubnetResourceId="${RESOURCEID_SUBNET_JUMPBOX}"
    ```
 
 ### Build and deploy the jump box image

docs/deploy/08-cluster-networking.md

@@ -33,10 +33,8 @@ Your `rg-enterprise-networking-spokes` will be populated with the dedicated regi
    > :eyes: If you're curious to see what changed in the regional hub, [view the diff](https://diffviewer.azureedge.net/?l=https://raw.githubusercontent.com/mspnp/aks-baseline-regulated/main/networking/hub-region.v1.bicep&r=https://raw.githubusercontent.com/mspnp/aks-baseline-regulated/main/networking/hub-region.v2.bicep).
 
    ```bash
-   RESOURCEID_SUBNET_AIB=$(az deployment group show -g rg-enterprise-networking-spokes -n spoke-BU0001A0005-00 --query properties.outputs.imageBuilderSubnetResourceId.value -o tsv)
    RESOURCEID_SUBNET_NODEPOOLS="['$(az deployment group show -g rg-enterprise-networking-spokes -n spoke-BU0001A0005-01 --query "properties.outputs.nodepoolSubnetResourceIds.value | join ('\',\'',@)" -o tsv)']"
-   RESOURCEID_SUBNET_JUMPBOX=$(az deployment group show -g rg-enterprise-networking-spokes -n spoke-BU0001A0005-01 --query properties.outputs.jumpboxSubnetResourceId.value -o tsv)
-
+  
    # [This takes about seven minutes to run.]
    az deployment group create -g rg-enterprise-networking-hubs -f networking/hub-region.v2.bicep -p location=eastus2 aksImageBuilderSubnetResourceId="${RESOURCEID_SUBNET_AIB}" nodepoolSubnetResourceIds="${RESOURCEID_SUBNET_NODEPOOLS}" aksJumpboxSubnetResourceId="${RESOURCEID_SUBNET_JUMPBOX}"
    ```

networking/hub-region.v1.bicep

@@ -6,6 +6,10 @@ targetScope = 'resourceGroup'
 @minLength(79)
 param aksImageBuilderSubnetResourceId string
 
+@description('Subnet resource Id for the AKS jumpbox subnet')
+@minLength(79)
+param aksJumpboxSubnetResourceId string
+
 @allowed([
   'australiaeast'
   'canadacentral'
@@ -70,6 +74,24 @@ resource aksImageBuilderSubnet 'Microsoft.Network/virtualNetworks/subnets@2022-0
   name: last(split(aksImageBuilderSubnetResourceId, '/'))
 }
 
+@description('The resource group name containing virtual network in which Jumpbox will be dropped.')
+resource rgJumpBoxVirutalNetwork 'Microsoft.Resources/resourceGroups@2021-04-01' existing = {
+  scope: subscription()
+  name: split(aksJumpboxSubnetResourceId, '/')[4]
+}
+
+@description('Jumpbox Spoke Virtual Network')
+resource aksJumpBoxSpokeVnet 'Microsoft.Network/virtualNetworks@2022-01-01' existing = {
+  scope: rgJumpBoxVirutalNetwork
+  name: split(aksJumpboxSubnetResourceId, '/')[8]
+}
+
+@description('Jumpbox subnet')
+resource aksJumpboxSubnet 'Microsoft.Network/virtualNetworks/subnets@2022-01-01' existing = {
+  parent: aksJumpBoxSpokeVnet
+  name: last(split(aksJumpboxSubnetResourceId, '/'))
+}
+
 resource networkWatcherResourceGroup 'Microsoft.Resources/resourceGroups@2021-04-01' existing = if (deployFlowLogResources) {
   scope: subscription()
   name: 'networkWatcherRG'
@@ -480,6 +502,17 @@ resource imageBuilder_ipgroups 'Microsoft.Network/ipGroups@2021-05-01' = {
   }
 }
 
+@description('This holds IP addresses of known AKS Jumpbox image building subnets in attached spokes.')
+resource jumpbox_ipgroups 'Microsoft.Network/ipGroups@2021-05-01' = {
+  name: 'ipg-${location}-AksJumpboxes'
+  location: location
+  properties: {
+    ipAddresses: [
+      aksJumpboxSubnet.properties.addressPrefix
+    ]
+  }
+}
+
 resource region_flowlog_storageAccount_diagnosticSettings 'Microsoft.Insights/diagnosticSettings@2017-05-01-preview' = if (deployFlowLogResources) {
   name: 'default'
   scope: flowlogs_storageAccount::blobStorage

networking/hub-region.v2.bicep

@@ -905,6 +905,22 @@ resource hubFirewall 'Microsoft.Network/azureFirewalls@2021-05-01' = {
                 'login.microsoftonline.com'
               ]
             }
+            {
+              name: 'api-server-address'
+              description: 'Allow jumpboxes to perform kubectl.'
+              sourceIpGroups: [
+                aksJumpbox_ipgroup.id
+              ]
+              protocols: [
+                {
+                  protocolType: 'Https'
+                  port: 443
+                }
+              ]
+              targetFqdns: [
+                '*.privatelink.${location}.azmk8s.io'
+              ]
+            }
             {
               name: 'az-management-api'
               description: 'Allow jumpboxes to communicate with Azure management APIs.'