Skip to content

Commit 9f379b2

Browse files
danakjchromeos-ci-prod
authored and
chromeos-ci-prod
committed
Set Rust symbol visibility to hidden when C++ symbols are
This depended on rust-lang/rust#131519 rolling into the Rust compiler to fix builtins/intrinisics, which was merged in 33b1264540b. Remove ASAN ODR exceptions for Rust globals as they are no longer walked twice incorrectly when they are hidden. Disable the rust logging test in component builds for all platforms not just for Windows, now that symbol visibility is the same for all platforms. See https://crbug.com/374023535#comment13 Bug: 41484256, 40274892, 374023535 Fixed: 40278279 Cq-Include-Trybots: luci.chromium.try:linux-official,mac-official,win-official,win32-official Cq-Include-Trybots: luci.chromium.try:linux-asan-rel,mac-asan-rel,win-asan-rel Cq-Include-Trybots: luci.chromium.try:linux_chromium_dbg_ng Change-Id: I976ef679961e9db5a91bcc74f559ebbcc0bf058b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5966273 Commit-Queue: danakj <[email protected]> Reviewed-by: Arthur Eubanks <[email protected]> Cr-Commit-Position: refs/heads/main@{#1375460} CrOS-Libchrome-Original-Commit: ee3900fd57b3c580aefff15c64052904d81b7760
1 parent 5345f0b commit 9f379b2

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

base/logging/rust_log_integration_unittest.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@ class RustLogIntegrationTest : public testing::Test {
2020
base::test::MockLog log_;
2121
};
2222

23-
// TODO(crbug.com/374023535): Re-enable test.
24-
#if BUILDFLAG(IS_WIN) && !defined(NDEBUG)
23+
// TODO(crbug.com/374023535): Logging does not work in component builds.
24+
#if defined(COMPONENT_BUILD)
2525
#define MAYBE_CheckAllSeverity DISABLED_CheckAllSeverity
2626
#else
2727
#define MAYBE_CheckAllSeverity CheckAllSeverity

0 commit comments

Comments
 (0)