Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save and load 2D coordinates pre-normalization #92

Closed
mrozycki opened this issue Dec 5, 2022 · 0 comments · Fixed by #100
Closed

Save and load 2D coordinates pre-normalization #92

mrozycki opened this issue Dec 5, 2022 · 0 comments · Fixed by #100
Labels
configurator Changes in the configurator

Comments

@mrozycki
Copy link
Owner

mrozycki commented Dec 5, 2022

Since we might want to implement better pre-normalization filters in the future (see #86 and #87), we might want to re-run the configurator with previously captured light positions to take advantage of the improved algorithm. Currently the points are saved post-normalization, which means normalization is not re-ran when using pre-captured points. Technically normalization can be reversed, but that would also have to be implemented, and saving coordinates pre-normalization is easier.

In the scope of this task, change the 2D coordinates to be saved before normalization, rather than after.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
configurator Changes in the configurator
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant