Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: convert project to typescript #153

Open
robertsLando opened this issue Feb 18, 2025 · 3 comments
Open

feat: convert project to typescript #153

robertsLando opened this issue Feb 18, 2025 · 3 comments

Comments

@robertsLando
Copy link
Member

@mcollina would you accept such PR?

@mcollina
Copy link
Member

Why? What's the end goal? This project is stable and essentially "done".

@robertsLando
Copy link
Member Author

robertsLando commented Feb 24, 2025

From my experience re-writing projects using TS helps discover issues in the code that JS hides, also it's easier to apply any future update to the library giving that everything is type-safe then.

Also having to deal with #151 (comment) would make things easier to handle

@mcollina
Copy link
Member

Unless some significant feature is coming (like a new version of MQTT), it's not worth doing it.

Usually, it's harder to get typescript code to be as fast as JS, and a rewrite would require extensive benchmarks.

I'm not necessarily opposed, but given the amount of work needed on on MQTT.js, I don't think it's a good use of effort.

It might make sense doing it if we end up adding some support for the WHATWG specs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants