Skip to content

Commit bbc13b7

Browse files
committed
Remove template type parameter clauses from constructor declarations
This is to appease stricter checks with g++ -std=c++20, details in [this](proxy-wasm/proxy-wasm-cpp-host#411 (comment)) and subsequent comments. Signed-off-by: Michael Warres <[email protected]>
1 parent 6b3dc93 commit bbc13b7

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

proxy_wasm_api.h

+3-3
Original file line numberDiff line numberDiff line change
@@ -1712,7 +1712,7 @@ struct SimpleHistogram {
17121712
template <typename... Tags> struct Counter : public MetricBase {
17131713
static Counter<Tags...> *New(std::string_view name, MetricTagDescriptor<Tags>... fieldnames);
17141714

1715-
Counter<Tags...>(std::string_view name, MetricTagDescriptor<Tags>... descriptors)
1715+
Counter(std::string_view name, MetricTagDescriptor<Tags>... descriptors)
17161716
: Counter<Tags...>(std::string(name), std::vector<MetricTag>({toMetricTag(descriptors)...})) {
17171717
}
17181718

@@ -1763,7 +1763,7 @@ inline Counter<Tags...> *Counter<Tags...>::New(std::string_view name,
17631763
template <typename... Tags> struct Gauge : public MetricBase {
17641764
static Gauge<Tags...> *New(std::string_view name, MetricTagDescriptor<Tags>... fieldnames);
17651765

1766-
Gauge<Tags...>(std::string_view name, MetricTagDescriptor<Tags>... descriptors)
1766+
Gauge(std::string_view name, MetricTagDescriptor<Tags>... descriptors)
17671767
: Gauge<Tags...>(std::string(name), std::vector<MetricTag>({toMetricTag(descriptors)...})) {}
17681768

17691769
SimpleGauge resolve(Tags... f) {
@@ -1809,7 +1809,7 @@ inline Gauge<Tags...> *Gauge<Tags...>::New(std::string_view name,
18091809
template <typename... Tags> struct Histogram : public MetricBase {
18101810
static Histogram<Tags...> *New(std::string_view name, MetricTagDescriptor<Tags>... fieldnames);
18111811

1812-
Histogram<Tags...>(std::string_view name, MetricTagDescriptor<Tags>... descriptors)
1812+
Histogram(std::string_view name, MetricTagDescriptor<Tags>... descriptors)
18131813
: Histogram<Tags...>(std::string(name),
18141814
std::vector<MetricTag>({toMetricTag(descriptors)...})) {}
18151815

0 commit comments

Comments
 (0)