Fix error when using 'exists' validation without second argument

Author: mpociot

src/Mpociot/ApiDoc/Generators/AbstractGenerator.php

@@ -46,8 +46,8 @@ protected function getParameters($routeData, $routeAction, $bindings)
                 'value' => '',
                 'description' => [],
             ];
-            foreach ($rules as $rule) {
-                $this->parseRule($rule, $attributeData, $routeData['id']);
+            foreach ($rules as $ruleName => $rule) {
+                $this->parseRule($rule, $attribute, $attributeData, $routeData['id']);
             }
             $routeData['parameters'][$attribute] = $attributeData;
         }
@@ -181,11 +181,13 @@ protected function fancyImplode($arr, $first, $last)
 
     /**
      * @param  string  $rule
+     * @param  string  $ruleName
      * @param  array  $attributeData
+     * @param  int  $seed
      *
      * @return void
      */
-    protected function parseRule($rule, &$attributeData, $seed)
+    protected function parseRule($rule, $ruleName, &$attributeData, $seed)
     {
         $faker = Factory::create();
         $faker->seed(crc32($seed));
@@ -300,7 +302,8 @@ protected function parseRule($rule, &$attributeData, $seed)
                 $attributeData['value'] = $faker->timezone;
                 break;
             case 'exists':
-                $attributeData['description'][] = Description::parse($rule)->with([Str::singular($parameters[0]), $parameters[1]])->getDescription();
+                $fieldName = isset($parameters[1]) ? $parameters[1] : $ruleName;
+                $attributeData['description'][] = Description::parse($rule)->with([Str::singular($parameters[0]), $fieldName])->getDescription();
                 break;
             case 'active_url':
                 $attributeData['type'] = 'url';

tests/ApiDocGeneratorTest.php

@@ -186,6 +186,12 @@ public function testCanParseFormRequestRules()
                     $this->assertCount(1, $attribute['description']);
                     $this->assertSame('Valid user firstname', $attribute['description'][0]);
                     break;
+                case 'single_exists':
+                    $this->assertFalse($attribute['required']);
+                    $this->assertSame('string', $attribute['type']);
+                    $this->assertCount(1, $attribute['description']);
+                    $this->assertSame('Valid user single_exists', $attribute['description'][0]);
+                    break;
                 case 'image':
                     $this->assertFalse($attribute['required']);
                     $this->assertSame('image', $attribute['type']);

tests/DingoGeneratorTest.php

@@ -189,6 +189,12 @@ public function testCanParseFormRequestRules()
                     $this->assertCount(1, $attribute['description']);
                     $this->assertSame('Valid user firstname', $attribute['description'][0]);
                     break;
+                case 'single_exists':
+                    $this->assertFalse($attribute['required']);
+                    $this->assertSame('string', $attribute['type']);
+                    $this->assertCount(1, $attribute['description']);
+                    $this->assertSame('Valid user single_exists', $attribute['description'][0]);
+                    break;
                 case 'image':
                     $this->assertFalse($attribute['required']);
                     $this->assertSame('image', $attribute['type']);

tests/Fixtures/DingoTestRequest.php

@@ -26,6 +26,7 @@ public function rules()
             'digits' => 'digits:2',
             'digits_between' => 'digits_between:2,10',
             'exists' => 'exists:users,firstname',
+            'single_exists' => 'exists:users',
             'in' => 'in:jpeg,png,bmp,gif,svg',
             'integer' => 'integer',
             'ip' => 'ip',

tests/Fixtures/TestRequest.php

@@ -26,6 +26,7 @@ public function rules()
             'digits' => 'digits:2',
             'digits_between' => 'digits_between:2,10',
             'exists' => 'exists:users,firstname',
+            'single_exists' => 'exists:users',
             'in' => 'in:jpeg,png,bmp,gif,svg',
             'integer' => 'integer',
             'ip' => 'ip',