Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show "end game" screen instead of exiting the game and showing a terminal message #18

Open
mpereira opened this issue Nov 5, 2017 · 6 comments

Comments

@mpereira
Copy link
Owner

mpereira commented Nov 5, 2017

Also allow the player to play again by pressing spacebar or quitting the game by pressing q like in the greeting screen.

@mpereira mpereira mentioned this issue Nov 5, 2017
@mpereira mpereira changed the title Show "end game" screen instead of quitting the game and showing a terminal message Show "end game" screen instead of exiting the game and showing a terminal message Nov 5, 2017
@greno4ka
Copy link
Contributor

greno4ka commented May 7, 2018

I ll try to find some more time to release a PR for allowing player to play again. #22

@basxto
Copy link
Contributor

basxto commented Jan 14, 2019

One could write “You won” on the cards in the top right and on the empty stacks.
But for this it would be necessary to automatically move the cards to the top right.

┏━━━━━━━┳━━━━━━━┳━━━━━━━┳━━━━━━━┓
┃Y♥     ┃O♦     ┃U♣     ┃ ♠     ┃
┃       ┃       ┃       ┃       ┃
┃       ┃       ┃       ┃       ┃
┃       ┃       ┃       ┃       ┃
┃      ♥┃     W♦┃     O♣┃     N♠┃
┗━━━━━━━┻━━━━━━━┻━━━━━━━┻━━━━━━━┛

┌─────┐ ┌─────┐ ┌─────┐ ┌─────┐ ┌─────┐ ┌─────┐ ┌─────┐
│█   █│ │ ███ │ │█  █ │ │     │ │█   █│ │ ███ │ │██  █│
│ ███ │ │█   █│ │█  █ │ │     │ │█ █ █│ │█   █│ │█ █ █│
│  █  │ │ ███ │ │ ██  │ │     │ │ █ █ │ │ ███ │ │█  ██│
└─────┘ └─────┘ └─────┘ └─────┘ └─────┘ └─────┘ └─────┘

@greno4ka
Copy link
Contributor

Cool! I can try to make a PR on this.

@greno4ka
Copy link
Contributor

The problem is that card has 7 chars in width and 5 chars in height. So I can't imagine letters with such sizes. And I think my previous PR was much more beautiful!

@dther
Copy link
Contributor

dther commented Jun 1, 2020

I'm thinking of making some kind of "solving" animation, so that we can finally have a bit more fanfare than a quit and a terminal message. I think @greno4ka's pull request could look really nice on the solved board!

@mpereira
Copy link
Owner Author

mpereira commented Jun 1, 2020

@dther sounds cool. Regarding the "end message" I was thinking something simpler would be best. For example, just a "You won!" message wrote in text somewhere on the board. Future functionality could also include showing the time to win, and amount of points.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants