Skip to content

Commit aa737b2

Browse files
committed
[UI] Support directly adding an internal bug
1 parent c0d6fd9 commit aa737b2

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

ui/job-view/details/PinBoard.jsx

+8-4
Original file line numberDiff line numberDiff line change
@@ -358,16 +358,20 @@ class PinBoard extends React.Component {
358358
);
359359
};
360360

361-
isNumber = (text) => !text || /^[0-9]*$/.test(text);
361+
isValidBugNumber = (text) => !text || /^i?[0-9]*$/.test(text);
362362

363363
saveEnteredBugNumber = () => {
364364
const { newBugNumber, enteringBugNumber } = this.state;
365365

366366
if (enteringBugNumber) {
367367
if (!newBugNumber) {
368368
this.toggleEnterBugNumber(false);
369-
} else if (this.isNumber(newBugNumber)) {
370-
this.props.addBug({ id: parseInt(newBugNumber, 10) });
369+
} else if (this.isValidBugNumber(newBugNumber)) {
370+
if (newBugNumber[0] === 'i') {
371+
this.props.addBug({ internal_id: newBugNumber.slice(1) });
372+
} else {
373+
this.props.addBug({ id: parseInt(newBugNumber, 10) });
374+
}
371375
this.toggleEnterBugNumber(false);
372376
}
373377
}
@@ -491,7 +495,7 @@ class PinBoard extends React.Component {
491495
pattern="[0-9]*"
492496
className="add-related-bugs-input"
493497
placeholder="enter bug number"
494-
invalid={!this.isNumber(newBugNumber)}
498+
invalid={!this.isValidBugNumber(newBugNumber)}
495499
onKeyPress={this.bugNumberKeyPress}
496500
onChange={(ev) => {
497501
this.setState({ newBugNumber: ev.target.value });

0 commit comments

Comments
 (0)