Count occurrences when classifying a pinned issue

Author: vrigal

ui/helpers/constants.js

@@ -341,6 +341,7 @@ export const thEvents = {
   applyNewJobs: 'apply-new-jobs-EVT',
   filtersUpdated: 'filters-updated-EVT',
   clearPinboard: 'clear-pinboard-EVT',
+  internalIssueClassification: 'internal-issue-classification-EVT',
 };
 
 export const thBugSuggestionLimit = 20;

ui/job-view/details/PinBoard.jsx

@@ -166,6 +166,15 @@ class PinBoard extends React.Component {
         const message = `Error saving bug association for ${job.platform} ${job.job_type_name}`;
         notify(formatModelError(response, message), 'danger');
       });
+
+      // In case the bug is still an internal issue, check if the required number of occurrence is reached to open a bug
+      if (!bug.id) {
+        window.dispatchEvent(
+          new CustomEvent(thEvents.internalIssueClassification, {
+            detail: { internalBugId: bug.internal_id },
+          }),
+        );
+      }
     });
   };
 

ui/shared/tabs/failureSummary/FailureSummaryTab.jsx

@@ -34,6 +34,10 @@ class FailureSummaryTab extends React.Component {
 
   componentDidMount() {
     this.loadBugSuggestions();
+
+    window.addEventListener(thEvents.internalIssueClassification, (event) =>
+      this.checkInternalFailureOccurrences(event.detail.internalBugId),
+    );
   }
 
   componentDidUpdate(prevProps) {
@@ -89,20 +93,16 @@ class FailureSummaryTab extends React.Component {
     window.open(data.url);
   };
 
-  internalIssueFilerCallback = async (data) => {
-    const { addBug } = this.props;
+  checkInternalFailureOccurrences = (bugInternalId) => {
+    // Try matching an internal bug already fetched with enough occurences
     const { suggestion, suggestions } = this.state;
 
-    await addBug({ ...data, newBug: `i${data.internal_id}` });
-    window.dispatchEvent(new CustomEvent(thEvents.saveClassification));
-
-    // Try matching an internal bug already fetched with enough occurences
     const internalBugs = suggestions
       .map((s) => s.bugs.open_recent)
       .flat()
       .filter((bug) => bug.id === null);
     const existingBug = internalBugs.filter(
-      (bug) => bug.internal_id === data.internal_id,
+      (bug) => bug.internal_id === bugInternalId,
     )[0];
     // Check if we reached the required number of occurrence to open a bug in Bugzilla
     if (
@@ -114,6 +114,15 @@ class FailureSummaryTab extends React.Component {
     }
   };
 
+  internalIssueFilerCallback = async (data) => {
+    const { addBug } = this.props;
+
+    await addBug({ ...data, newBug: `i${data.internal_id}` });
+    window.dispatchEvent(new CustomEvent(thEvents.saveClassification));
+
+    this.checkInternalFailureOccurrences(data.internal_id);
+  };
+
   loadBugSuggestions = () => {
     const { selectedJob } = this.props;