Skip to content

Commit 6fb7c3c

Browse files
committed
Bug 1923703 -Reduce frequency of geckoview performance tests r=kshampur,perftest-reviewers,taskgraph-reviewers,bhearsum
Differential Revision: https://phabricator.services.mozilla.com/D229113
1 parent 1ce7152 commit 6fb7c3c

File tree

4 files changed

+197
-244
lines changed

4 files changed

+197
-244
lines changed

.cron.yml

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -146,6 +146,18 @@ jobs:
146146
- {weekday: 'Wednesday', hour: 10, minute: 30}
147147
- {weekday: 'Friday', hour: 10, minute: 30}
148148

149+
- name: geckoview-perftest
150+
job:
151+
type: decision-task
152+
treeherder-symbol: gve-perftests
153+
target-tasks-method: geckoview-perftest
154+
include-push-tasks: true
155+
run-on-projects:
156+
- mozilla-central
157+
when:
158+
- {weekday: 'Monday', hour: 10, minute: 30}
159+
- {weekday: 'Thursday', hour: 10, minute: 30}
160+
149161
- name: custom-car-perf-testing
150162
job:
151163
type: decision-task

taskcluster/gecko_taskgraph/target_tasks.py

Lines changed: 31 additions & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -838,18 +838,9 @@ def filter(task):
838838
if "fenix" in try_name:
839839
if "-power" in try_name:
840840
return True
841-
# Select geckoview resource usage tests
841+
842842
if "geckoview" in try_name:
843-
# Run cpu+memory, and power tests
844-
cpu_n_memory_task = "-cpu" in try_name and "-memory" in try_name
845-
power_task = "-power" in try_name
846-
# Ignore cpu+memory+power tests
847-
if power_task and cpu_n_memory_task:
848-
return False
849-
if cpu_n_memory_task:
850-
return False
851-
if power_task:
852-
return "browsertime" in try_name
843+
return False
853844
# Select browsertime-specific tests
854845
if "browsertime" in try_name:
855846
# Don't run android CaR sp tests as we already have a cron for this.
@@ -869,6 +860,32 @@ def filter(task):
869860
return [l for l, t in full_task_graph.tasks.items() if filter(t)]
870861

871862

863+
@register_target_task("geckoview-perftest")
864+
def target_tasks_geckoview_perftest(full_task_graph, parameters, graph_config):
865+
"""
866+
Select tasks required for running geckoview tests 2 times a week.
867+
"""
868+
869+
def filter(task):
870+
platform = task.attributes.get("test_platform")
871+
attributes = task.attributes
872+
if attributes.get("unittest_suite") != "raptor":
873+
return False
874+
875+
if accept_raptor_android_build(platform):
876+
try_name = attributes.get("raptor_try_name")
877+
if "geckoview" in try_name and "browsertime" in try_name:
878+
if "hw-s24" in platform and "speedometer" not in try_name:
879+
return False
880+
if "live" in try_name and "cnn-amp" not in try_name:
881+
return False
882+
return True
883+
884+
return False
885+
886+
return [l for l, t in full_task_graph.tasks.items() if filter(t)]
887+
888+
872889
def make_desktop_nightly_filter(platforms):
873890
"""Returns a filter that gets all nightly tasks on the given platform."""
874891

@@ -1338,22 +1355,8 @@ def filter(task):
13381355
if "benchmark" in try_name:
13391356
return True
13401357
elif accept_raptor_android_build(platform):
1341-
# Select browsertime & geckoview specific tests
13421358
if "browsertime" and "geckoview" in try_name:
1343-
if "power" in try_name:
1344-
return False
1345-
if "cpu" in try_name:
1346-
return False
1347-
if "profiling" in try_name:
1348-
return False
1349-
if "-live" in try_name:
1350-
return False
1351-
if "speedometer" in try_name:
1352-
return True
1353-
if "webgl" in try_name:
1354-
return True
1355-
if "tp6m" in try_name:
1356-
return True
1359+
return False
13571360

13581361
return False
13591362

@@ -1404,24 +1407,9 @@ def filter(task):
14041407
if "youtube-playback" in try_name:
14051408
return True
14061409
elif accept_raptor_android_build(platform):
1407-
# Select browsertime & geckoview specific tests
1410+
14081411
if "browsertime" and "geckoview" in try_name:
1409-
if "power" in try_name:
1410-
return False
1411-
if "cpu" in try_name:
1412-
return False
1413-
if "profiling" in try_name:
1414-
return False
1415-
if "-live" in try_name:
1416-
return False
1417-
if "speedometer" in try_name:
1418-
return True
1419-
if "webgl" in try_name:
1420-
return True
1421-
if "tp6m" in try_name:
1422-
return True
1423-
if "youtube-playback" in try_name:
1424-
return True
1412+
return False
14251413

14261414
return False
14271415

taskcluster/kinds/test/browsertime-mobile.yml

Lines changed: 10 additions & 57 deletions
Original file line numberDiff line numberDiff line change
@@ -128,26 +128,7 @@ browsertime-tp6m:
128128
- youtube
129129
run-on-projects:
130130
by-app:
131-
geckoview:
132-
by-variant:
133-
geckoview-no-fission:
134-
by-test-platform:
135-
android-hw-a55.*shippable.*: [trunk-only]
136-
default: []
137-
default:
138-
by-subtest:
139-
wikipedia:
140-
by-test-platform:
141-
android-hw-a55.*shippable.*: []
142-
default: []
143-
google-search-restaurants:
144-
by-test-platform:
145-
android-hw-a55.*shippable.*: []
146-
default: []
147-
default:
148-
by-test-platform:
149-
android-hw-a55.*shippable.*: []
150-
default: []
131+
geckoview: []
151132
fenix:
152133
by-variant:
153134
geckoview-no-fission:
@@ -174,16 +155,7 @@ browsertime-tp6m-essential:
174155
- [youtube-watch, youtube-w]
175156
run-on-projects:
176157
by-app:
177-
geckoview:
178-
by-subtest:
179-
allrecipes:
180-
by-test-platform:
181-
android-hw-a55.*shippable.*: [trunk]
182-
default: []
183-
default:
184-
by-test-platform:
185-
android-hw-a55.*shippable.*: [trunk-only]
186-
default: []
158+
geckoview: []
187159
fenix:
188160
by-test-platform:
189161
android-hw-a55.*shippable.*: [trunk-only]
@@ -275,10 +247,7 @@ browsertime-youtube-playback-mobile:
275247
by-test-platform:
276248
android-hw-a55.*shippable.*: [mozilla-central]
277249
default: []
278-
geckoview:
279-
by-test-platform:
280-
android-hw-a55.*shippable.*: [mozilla-central]
281-
default: []
250+
geckoview: []
282251
default: []
283252
max-run-time: 3600
284253

@@ -301,10 +270,7 @@ browsertime-youtube-playback-power-mobile:
301270
by-test-platform:
302271
android-hw-a55.*shippable.*: [autoland, mozilla-central]
303272
default: []
304-
geckoview:
305-
by-test-platform:
306-
android-hw-a55.*shippable.*: [autoland, mozilla-central]
307-
default: []
273+
geckoview: []
308274
default: []
309275
max-run-time: 1800
310276
mozharness:
@@ -366,10 +332,7 @@ browsertime-tp6m-live:
366332
by-subtest:
367333
cnn-ampstories:
368334
by-app:
369-
geckoview:
370-
by-test-platform:
371-
android-hw-a55.*shippable.*: [autoland]
372-
default: []
335+
geckoview: []
373336
default: []
374337
default: []
375338
tier: 3
@@ -414,6 +377,7 @@ browsertime-video-playback-latency-mobile:
414377
run-on-projects:
415378
by-app:
416379
chrome-m: []
380+
geckoview: []
417381
default:
418382
by-test-platform:
419383
android-hw-a55.*shippable.*: [autoland, mozilla-central]
@@ -434,10 +398,7 @@ browsertime-benchmark-speedometer-mobile:
434398
by-test-platform:
435399
android-hw-a55.*shippable.*: [trunk]
436400
default: []
437-
geckoview:
438-
by-test-platform:
439-
android-hw-a55.*shippable.*: [trunk]
440-
default: []
401+
geckoview: []
441402
cstm-car-m:
442403
by-test-platform:
443404
android-hw-p6.*shippable.*: []
@@ -468,12 +429,7 @@ browsertime-benchmark-speedometer3-mobile:
468429
android-hw-p6.*shippable.*: [mozilla-central]
469430
android-hw-s24.*shippable.*: [mozilla-central]
470431
default: []
471-
geckoview:
472-
by-test-platform:
473-
android-hw-a55.*shippable.*: [trunk-only]
474-
android-hw-p6.*shippable.*: [mozilla-central]
475-
android-hw-s24.*shippable.*: [mozilla-central]
476-
default: []
432+
geckoview: []
477433
cstm-car-m: [mozilla-central]
478434
chrome-m:
479435
by-test-platform:
@@ -496,6 +452,7 @@ browsertime-benchmark-motionmark-1-3:
496452
run-on-projects:
497453
by-app:
498454
chrome-m: []
455+
geckoview: []
499456
default:
500457
by-test-platform:
501458
android-hw-a55.*shippable.*: [mozilla-central]
@@ -538,11 +495,7 @@ browsertime-benchmark-unity-webgl-mobile:
538495
run-on-projects:
539496
by-app:
540497
refbrow: []
541-
geckoview:
542-
by-test-platform:
543-
# Disabled on autoland due to bug 1720063, and bug 1795826
544-
android-hw-a55.*shippable.*: [mozilla-central]
545-
default: []
498+
geckoview: []
546499
default:
547500
by-test-platform:
548501
android-hw-a55.*shippable.*: [mozilla-central]

0 commit comments

Comments
 (0)