Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

Commit 2d03564

Browse files
committed
Bug 1830265 - Tidy up .prettierignore. r=Gijs,sync-reviewers,markh
Enables Prettier for (these don't need to be excluded): - extensions/pref/autoconfig/test/unit/autoconfig.js - services/sync/tests/unit/prefs_test_prefs_store.js Removes duplications where the files are already ignored in the .eslintignore section. Re-organises the structure of the remaining parts to make it clearer why they are being excluded. Differential Revision: https://phabricator.services.mozilla.com/D176636
1 parent 0260a3c commit 2d03564

File tree

4 files changed

+12
-39
lines changed

4 files changed

+12
-39
lines changed

.eslintignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,7 @@ devtools/client/webconsole/test/browser/test-autocomplete-mapped.src.js
9090
devtools/client/inspector/markup/test/shadowdom_open_debugger.min.js
9191
devtools/client/webconsole/test/browser/test-click-function-to-source*.js
9292
devtools/client/webconsole/test/browser/test-external-script-errors.js
93+
devtools/client/webconsole/test/browser/test-mangled-function.*
9394
devtools/client/webconsole/test/browser/test-message-categories-canvas-css.js
9495
devtools/client/webconsole/test/browser/test-message-categories-empty-getelementbyid.js
9596
devtools/client/webconsole/test/browser/test-sourcemap*.js

.prettierignore

Lines changed: 7 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -14,55 +14,24 @@
1414
# This should be re-enabled in bug 1827456.
1515
js/src/builtin
1616

17-
1817
# Don't format README files.
1918
README
2019

21-
# Ignore default pref files which have a .js suffix but aren't parsed normally as JavaScript.
22-
browser/app/profile/channel-prefs.js
23-
browser/app/profile/firefox.js
24-
browser/branding/aurora/pref/firefox-branding.js
25-
browser/branding/nightly/pref/firefox-branding.js
26-
browser/branding/official/pref/firefox-branding.js
27-
browser/branding/unofficial/pref/firefox-branding.js
28-
devtools/client/preferences/debugger.js
29-
extensions/pref/autoconfig/test/unit/autoconfig.js
30-
mobile/android/app/geckoview-prefs.js
31-
mobile/android/app/mobile.js
32-
mobile/android/installer/mobile-l10n.js
33-
modules/libpref/init/all.js
34-
modules/libpref/test/unit/data/testParser.js
35-
modules/libpref/test/unit/data/testPrefLocked.js
36-
modules/libpref/test/unit/data/testPrefSticky.js
37-
modules/libpref/test/unit/extdata/testExt.js
38-
services/sync/tests/unit/prefs_test_prefs_store.js
39-
4020
# Ignore CORS fixtures which require specific resource hashes.
4121
dom/security/test/sri/script*
4222

43-
# Ignore other DOM fixtures with funky chars.
23+
# Files that are intentionally broken for tests.
4424
dom/base/test/file_bug687859-charset.js
4525
dom/base/test/file_bug687859-inherit.js
26+
parser/htmlparser/tests/mochitest/broken_xml.xhtml
27+
parser/htmlparser/tests/mochitest/test_bug563322.xhtml
4628

47-
# Ignore devtools debugger files
48-
devtools/client/debugger/src/test/examples/**
49-
devtools/client/debugger/src/test/integration/**
50-
devtools/client/debugger/src/test/unit-sources/**
29+
# Files that are specific formats/layouts for tests.
5130
devtools/client/debugger/src/**/fixtures/**
52-
devtools/client/debugger/src/test/mochitest/**
5331

54-
# These are source mapped and the locations are asserted in the test case.
55-
devtools/client/webconsole/test/browser/test-mangled-function.*
56-
57-
# This file is based on another and we want to keep the syntax the same.
32+
# Imported files where we don't want to change the format, but we do want ESLint
33+
# to keep an eye on them (hence not in Generated.txt/ThirdPartyFiles.txt)
5834
devtools/shared/plural-form.js
59-
60-
# Intentionally broken files
61-
parser/htmlparser/tests/mochitest/broken_xml.xhtml
62-
parser/htmlparser/tests/mochitest/test_bug563322.xhtml
63-
64-
# A mainly-imported file, that we don't want to format, but want to keep an eye
65-
# on with the other imported files.
6635
toolkit/components/formautofill/shared/CreditCardRuleset.sys.mjs
6736

6837
##############################################################################
@@ -148,6 +117,7 @@ devtools/client/webconsole/test/browser/test-autocomplete-mapped.src.js
148117
devtools/client/inspector/markup/test/shadowdom_open_debugger.min.js
149118
devtools/client/webconsole/test/browser/test-click-function-to-source*.js
150119
devtools/client/webconsole/test/browser/test-external-script-errors.js
120+
devtools/client/webconsole/test/browser/test-mangled-function.*
151121
devtools/client/webconsole/test/browser/test-message-categories-canvas-css.js
152122
devtools/client/webconsole/test/browser/test-message-categories-empty-getelementbyid.js
153123
devtools/client/webconsole/test/browser/test-sourcemap*.js

extensions/pref/autoconfig/test/unit/autoconfig.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,3 @@ pref("general.config.sandbox_enabled", true);
33
pref("general.config.filename", "autoconfig.cfg");
44
pref("general.config.vendor", "autoconfig");
55
pref("general.config.obscure_value", 0);
6-

services/sync/tests/unit/prefs_test_prefs_store.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,10 @@ user_pref("testing.dont.change", "Please don't change me.");
3030
user_pref("testing.turned.off", "I won't get synced.");
3131
user_pref("testing.not.turned.on", "I won't get synced either!");
3232
// Some url we don't want to sync
33-
user_pref("testing.unsynced.url", "moz-extension://d5d31b00-b944-4afb-bd3d-d0326551a0ae");
33+
user_pref(
34+
"testing.unsynced.url",
35+
"moz-extension://d5d31b00-b944-4afb-bd3d-d0326551a0ae"
36+
);
3437
user_pref("testing.synced.url", "https://www.example.com");
3538

3639
// A pref that exists but still has the default value - will be synced with

0 commit comments

Comments
 (0)