Bug 1881925 - standardize on more manifest conditions. r=aryx,credential-management-reviewers,devtools-reviewers,dom-storage-reviewers,omc-reviewers,nchevobbe,janv,issammani

Differential Revision: https://phabricator.services.mozilla.com/D202663

Author: jmaher

browser/base/content/test/about/browser.toml

@@ -34,7 +34,8 @@ support-files = [
 ["browser_aboutHome_search_suggestion.js"]
 skip-if = [
   "os == 'mac'",
-  "os == 'linux' && (!debug || bits == 64)",
+  "os == 'linux' && os_version == '18.04' && !debug",
+  "os == 'linux' && os_version == '18.04' && bits == 64",
   "win10_2009 && bits == 64 && !debug", # Bug 1399648, bug 1402502
 ]
 
@@ -75,14 +76,17 @@ skip-if = ["tsan"] # Bug 1676326, highly frequent on TSan
 ["browser_aboutStopReload.js"]
 
 ["browser_aboutSupport.js"]
-skip-if = ["os == 'linux' && bits == 64 && asan && !debug"] # Bug 1713368
+skip-if = ["os == 'linux' && os_version == '18.04' && asan"] # Bug 1713368
 
 ["browser_aboutSupport_newtab_security_state.js"]
 
 ["browser_aboutSupport_places.js"]
 skip-if = ["os == 'android'"]
 
 ["browser_bug435325.js"]
-skip-if = ["verify && !debug && os == 'mac'"]
+skip-if = [
+  "apple_catalina && !debug && verify",
+  "apple_silicon && !debug && verify",
+]
 
 ["browser_bug633691.js"]

browser/components/extensions/test/browser/browser.toml

@@ -49,7 +49,7 @@ support-files = [
   "../../../../../toolkit/components/reader/test/readerModeNonArticle.html",
   "../../../../../toolkit/components/reader/test/readerModeArticle.html",
 ]
-skip-if = ["os == 'linux' && asan"] # Bug 1721945 - Software WebRender
+skip-if = ["os == 'linux' && os_version == '18.04' && asan"] # Bug 1721945 - Software WebRender
 
 ["browser_AMBrowserExtensionsImport.js"]
 
@@ -75,12 +75,12 @@ disabled = "bug 1438663 # same focus issue as Bug 1438663"
 ["browser_ext_browserAction_context.js"]
 https_first_disabled = true
 skip-if = [
-  "os == 'linux' && debug", # Bug 1504096
-  "os == 'linux' && socketprocess_networking",
+  "os == 'linux' && os_version == '18.04' && debug", # Bug 1504096
+  "os == 'linux' && os_version == '18.04' && socketprocess_networking",
 ]
 
 ["browser_ext_browserAction_contextMenu.js"]
-skip-if = ["os == 'linux'"] # bug 1369197
+skip-if = ["os == 'linux' && os_version == '18.04'"] # bug 1369197
 
 ["browser_ext_browserAction_disabled.js"]
 
@@ -132,8 +132,9 @@ skip-if = ["debug"] # Bug 1522164
 
 ["browser_ext_commands_execute_page_action.js"]
 skip-if = [
-  "verify && os == 'linux'",
-  "verify && os == 'mac'",
+  "os == 'linux' && os_version == '18.04' && verify",
+  "apple_catalina && verify",
+  "apple_silicon && verify",
 ]
 
 ["browser_ext_commands_execute_sidebar_action.js"]
@@ -230,8 +231,9 @@ support-files = ["../../../../../devtools/client/inspector/extensions/test/head_
 ["browser_ext_find.js"]
 https_first_disabled = true
 skip-if = [
-  "verify && os == 'linux'",
-  "verify && os == 'mac'",
+  "os == 'linux' && os_version == '18.04' && verify",
+  "apple_catalina && verify",
+  "apple_silicon && verify",
 ]
 
 ["browser_ext_getViews.js"]
@@ -303,8 +305,9 @@ https_first_disabled = true
 
 ["browser_ext_openPanel.js"]
 skip-if = [
-  "verify && !debug && os == 'linux'",
-  "verify && !debug && os == 'mac'",
+  "os == 'linux' && os_version == '18.04' && !debug && verify",
+  "apple_catalina && !debug && verify",
+  "apple_silicon && !debug && verify",
 ]
 
 ["browser_ext_optionsPage_activity.js"]
@@ -328,14 +331,17 @@ https_first_disabled = true
 
 ["browser_ext_pageAction_context.js"]
 https_first_disabled = true
-skip-if = ["verify && !debug && os == 'linux'"]
+skip-if = ["os == 'linux' && os_version == '18.04' && !debug && verify"]
 
 ["browser_ext_pageAction_contextMenu.js"]
 
 ["browser_ext_pageAction_popup.js"]
 
 ["browser_ext_pageAction_popup_resize.js"]
-skip-if = ["verify && debug && os == 'mac'"]
+skip-if = [
+  "apple_catalina && debug && verify",
+  "apple_silicon && debug && verify",
+]
 
 ["browser_ext_pageAction_show_matches.js"]
 https_first_disabled = true
@@ -487,8 +493,9 @@ https_first_disabled = true
 ["browser_ext_tabs_discard_reversed.js"]
 https_first_disabled = true
 skip-if = [
-  "os == 'mac'", # Bug 1722607
-  "os == 'linux' && debug", #Bug 1722607
+  "apple_silicon", # Bug 1722607
+  "apple_catalina", # Bug 1722607
+  "os == 'linux' && os_version == '18.04' && debug", #Bug 1722607
 ]
 
 ["browser_ext_tabs_discarded.js"]
@@ -641,7 +648,10 @@ https_first_disabled = true
 ["browser_ext_webRequest_error_after_stopped_or_closed.js"]
 
 ["browser_ext_webrtc.js"]
-skip-if = ["os == 'mac'"] # Bug 1565738
+skip-if = [
+  "apple_catalina", # Bug 1565738
+  "apple_silicon", # Bug 1565738
+]
 
 ["browser_ext_windows.js"]
 https_first_disabled = true
@@ -650,7 +660,10 @@ https_first_disabled = true
 https_first_disabled = true
 
 ["browser_ext_windows_create.js"]
-skip-if = ["verify && os == 'mac'"]
+skip-if = [
+  "apple_catalina && verify",
+  "apple_silicon && verify",
+]
 tags = "fullscreen"
 
 ["browser_ext_windows_create_cookieStoreId.js"]
@@ -670,13 +683,15 @@ https_first_disabled = true
 
 ["browser_ext_windows_size.js"]
 skip-if = [
-  "os == 'mac'",
+  "apple_catalina",
+  "apple_silicon",
   "os == 'linux' && os_version == '18.04' && debug", # Fails when windows are randomly opened in fullscreen mode, Bug 1638027
 ]
 
 ["browser_ext_windows_update.js"]
 skip-if = [
-  "verify && os == 'mac'",
+  "apple_catalina && verify",
+  "apple_silicon && verify",
   "os == 'mac' && os_version == '10.15' && debug", # Bug 1780998
   "os == 'linux' && os_version == '18.04'", # Bug 1533982 for linux1804
 ]

browser/components/uitour/test/browser.toml

@@ -9,7 +9,7 @@ support-files = [
 
 ["browser_UITour.js"]
 skip-if = [
-  "os == 'linux'", # Intermittent failures, bug 951965
+  "os == 'linux' && os_version == '18.04'", # Intermittent failures, bug 951965
   "verify",
 ]
 
@@ -35,7 +35,7 @@ fail-if = ["a11y_checks"] # Bug 1854526 clicked UITourTooltipClose may not be fo
 ["browser_UITour_forceReaderMode.js"]
 
 ["browser_UITour_modalDialog.js"]
-skip-if = ["os != 'mac'"] # modal dialog disabling only working on OS X.
+run-if = ["os == 'mac'"] # modal dialog disabling only working on OS X.
 
 ["browser_UITour_observe.js"]
 
@@ -48,26 +48,30 @@ skip-if = ["true"] # Disabled pending removal of pocket UI Tour
 ["browser_UITour_private_browsing.js"]
 
 ["browser_UITour_resetProfile.js"]
-skip-if = ["verify && !debug && (os == 'linux')"]
+skip-if = ["os == 'linux' && os_version == '18.04' && !debug && verify"]
 
 ["browser_UITour_showNewTab.js"]
-skip-if = ["verify && !debug && (os == 'linux')"]
+skip-if = ["os == 'linux' && os_version == '18.04' && !debug && verify"]
 
 ["browser_UITour_showProtectionReport.js"]
-skip-if = ["os == 'linux' && (asan || debug || tsan)"] # Bug 1697217
+skip-if = [
+  "os == 'linux' && os_version == '18.04' && asan", # Bug 1697217
+  "os == 'linux' && os_version == '18.04' && debug", # Bug 1697217
+  "os == 'linux' && os_version == '18.04' && tsan", # Bug 1697217
+]
 
 ["browser_UITour_sync.js"]
 skip-if = [
-  "os == 'linux'", # Bug 1678417
+  "os == 'linux' && os_version == '18.04'", # Bug 1678417
 ]
 
 ["browser_UITour_toggleReaderMode.js"]
-skip-if = ["verify && !debug && (os == 'linux')"]
+skip-if = ["os == 'linux' && os_version == '18.04' && !debug && verify"]
 
 ["browser_backgroundTab.js"]
 
 ["browser_closeTab.js"]
-skip-if = ["verify && !debug && (os == 'linux')"]
+skip-if = ["os == 'linux' && os_version == '18.04' && !debug && verify"]
 
 ["browser_fxa.js"]
 

browser/extensions/formautofill/test/browser/creditCard/browser.toml

@@ -17,66 +17,73 @@ support-files = [
 ]
 
 ["browser_anti_clickjacking.js"]
-skip-if = ["!debug && os == 'mac'"] # perma-fail see Bug 1600059
+skip-if = [
+  "apple_catalina && !debug", # perma-fail see Bug 1600059
+  "apple_silicon && !debug", # perma-fail see Bug 1600059
+]
 
 ["browser_creditCard_capture_form_removal.js"]
 
 ["browser_creditCard_capture_page_navigation.js"]
 
 ["browser_creditCard_doorhanger_action.js"]
 skip-if = [
-  "!debug && os == 'mac'", # perma-fail see Bug 1655601
-  "os == 'win' && ccov",   # Bug 1655600
+  "apple_catalina && !debug", # perma-fail see Bug 1655601
+  "apple_silicon && !debug", # perma-fail see Bug 1655601
+  "win11_2009 && ccov",   # Bug 1655600
 ]
 
 ["browser_creditCard_doorhanger_display.js"]
 skip-if = [
-  "!debug && os == 'mac'", # perma-fail see Bug 1655601
-  "os == 'win' && ccov",   # Bug 1655600
+  "apple_catalina && !debug", # perma-fail see Bug 1655601
+  "apple_silicon && !debug", # perma-fail see Bug 1655601
+  "win11_2009 && ccov",   # Bug 1655600
 ]
 
 ["browser_creditCard_doorhanger_fields.js"]
 skip-if = [
-  "!debug && os == 'mac'", # perma-fail see Bug 1655601
-  "os == 'win' && ccov",   # Bug 1655600
+  "apple_catalina && !debug", # perma-fail see Bug 1655601
+  "apple_silicon && !debug", # perma-fail see Bug 1655601
+  "win11_2009 && ccov",   # Bug 1655600
 ]
 
 ["browser_creditCard_doorhanger_iframe.js"]
 skip-if = [
-  "!debug && os == 'mac'", # perma-fail see Bug 1655601
-  "os == 'win' && ccov",   # Bug 1655600
+  "apple_catalina && !debug", # perma-fail see Bug 1655601
+  "apple_silicon && !debug", # perma-fail see Bug 1655601
+  "win11_2009 && ccov",   # Bug 1655600
 ]
 
 ["browser_creditCard_doorhanger_logo.js"]
 skip-if = [
-  "!debug && os == 'mac'", # perma-fail see Bug 1655601
-  "os == 'win' && ccov",   # Bug 1655600
+  "apple_catalina && !debug", # perma-fail see Bug 1655601
+  "apple_silicon && !debug", # perma-fail see Bug 1655601
+  "win11_2009 && ccov",   # Bug 1655600
 ]
 
 ["browser_creditCard_doorhanger_not_shown.js"]
 skip-if = [
-  "!debug && os == 'mac'", # perma-fail see Bug 1655601
-  "os == 'win' && ccov",   # Bug 1655600
+  "apple_catalina && !debug", # perma-fail see Bug 1655601
+  "apple_silicon && !debug", # perma-fail see Bug 1655601
+  "win11_2009 && ccov",   # Bug 1655600
 ]
 
 ["browser_creditCard_doorhanger_sync.js"]
 skip-if = [
-  "!debug && os == 'mac'", # perma-fail see Bug 1655601
-  "os == 'win' && ccov",   # Bug 1655600
+  "apple_catalina && !debug", # perma-fail see Bug 1655601
+  "apple_silicon && !debug", # perma-fail see Bug 1655601
+  "win11_2009 && ccov",   # Bug 1655600
 ]
 
 ["browser_creditCard_dropdown_layout.js"]
-skip-if = [
-  "os == 'mac'",
-  "os == 'linux'",
-  "os == 'win'",
-]
+skip-if = ["true"]
 
 ["browser_creditCard_fill_cancel_login.js"]
 skip-if = [
-  "!debug && os == 'mac'",
-  "os == 'linux'",
-  "os == 'win'",
+  "apple_catalina && !debug",
+  "os == 'linux' && os_version == '18.04'",
+  "win10_2009",
+  "win11_2009",
 ]
 
 ["browser_creditCard_heuristics.js"]
@@ -100,22 +107,10 @@ skip-if = [
 ]
 
 ["browser_editCreditCardDialog.js"]
-skip-if = [
-  "os == 'mac'",   # perma-fail see Bug 1600059
-  "os == 'linux'", # perma-fail see Bug 1600059
-  "os == 'win'",   # perma-fail see Bug 1600059
-]
+skip-if = ["true"] # perma-fail see Bug 1600059
 
 ["browser_insecure_form.js"]
-skip-if = [
-  "os == 'mac'",   # bug 1456284
-  "os == 'linux'", # bug 1456284
-  "os == 'win'",   # bug 1456284
-]
+skip-if = ["true"] # perma-fail see Bug 1456284
 
 ["browser_manageCreditCardsDialog.js"]
-skip-if = [
-  "os == 'mac'",
-  "os == 'linux'",
-  "os == 'win'",
-]
+skip-if = ["true"]

devtools/client/inspector/computed/test/browser.toml

@@ -34,7 +34,8 @@ fail-if = ["a11y_checks"] # Bug 1849028 clicked element may not be focusable and
 
 ["browser_computed_getNodeInfo.js"]
 skip-if = [
-  "!debug && os == 'mac'", #Bug 1559033
+  "apple_catalina && !debug", #Bug 1559033
+  "apple_silicon && !debug", #Bug 1559033
   "a11y_checks", # Bugs 1849028 and 1858041 to investigate intermittent a11y_checks results
 ]
 

devtools/client/netmonitor/src/har/test/browser.toml

@@ -21,8 +21,9 @@ support-files = [
 
 ["browser_net_har_copy_all_as_har.js"]
 skip-if = [
-  "!debug && os == 'mac'", #Bug 1622925
-  "!debug && os == 'linux'", #Bug 1622925
+  "apple_catalina && !debug", #Bug 1622925
+  "apple_silicon && !debug", #Bug 1622925
+  "os == 'linux' && os_version == '18.04' && !debug", #Bug 1622925
   "win11_2009", # Bug 1797751
 ]