Bug 1600481 : convert NS_STYLE_ISOLATION_* to an enum class in nsStyleConsts.h r=emilio

Differential Revision: https://phabricator.services.mozilla.com/D55378

--HG--
extra : moz-landing-system : lando

Author: jeffin143

layout/generic/nsFrame.cpp

@@ -10929,7 +10929,7 @@ bool nsIFrame::IsStackingContext(const nsStyleDisplay* aStyleDisplay,
                             aStylePosition->mZIndex.IsInteger())) ||
          (aStyleDisplay->mWillChange.bits &
           StyleWillChangeBits_STACKING_CONTEXT) ||
-         aStyleDisplay->mIsolation != NS_STYLE_ISOLATION_AUTO ||
+         aStyleDisplay->mIsolation != StyleIsolation::Auto ||
          aStyleEffects->HasBackdropFilters();
 }
 

layout/style/ServoBindings.toml

@@ -139,6 +139,7 @@ rusty-enums = [
     "mozilla::StyleTextAnchor",
     "mozilla::StyleObjectFit",
     "mozilla::StyleTopLayer",
+    "mozilla::StyleIsolation",
     "mozilla::StyleTextOrientation",
     "nsStyleImageType",
     "nsINode_BooleanFlag",

layout/style/nsStyleConsts.h

@@ -579,9 +579,10 @@ enum class StyleGridTrackBreadth : uint8_t {
 #define NS_STYLE_POINTER_EVENTS_ALL 8
 #define NS_STYLE_POINTER_EVENTS_AUTO 9
 
-// See nsStyleDisplay
-#define NS_STYLE_ISOLATION_AUTO 0
-#define NS_STYLE_ISOLATION_ISOLATE 1
+enum class StyleIsolation : uint8_t {
+  Auto,
+  Isolate,
+};
 
 // See nsStylePosition.mObjectFit
 enum class StyleObjectFit : uint8_t {

layout/style/nsStyleStruct.cpp

@@ -2678,7 +2678,7 @@ nsStyleDisplay::nsStyleDisplay(const Document& aDocument)
       mOverflowClipBoxInline(StyleOverflowClipBox::PaddingBox),
       mResize(StyleResize::None),
       mOrient(StyleOrient::Inline),
-      mIsolation(NS_STYLE_ISOLATION_AUTO),
+      mIsolation(StyleIsolation::Auto),
       mTopLayer(StyleTopLayer::None),
       mTouchAction(StyleTouchAction_AUTO),
       mScrollBehavior(NS_STYLE_SCROLL_BEHAVIOR_AUTO),

layout/style/nsStyleStruct.h

@@ -1528,7 +1528,7 @@ struct MOZ_NEEDS_MEMMOVABLE_MEMBERS nsStyleDisplay {
   mozilla::StyleOverflowClipBox mOverflowClipBoxInline;
   mozilla::StyleResize mResize;
   mozilla::StyleOrient mOrient;
-  uint8_t mIsolation;  // NS_STYLE_ISOLATION_*
+  mozilla::StyleIsolation mIsolation;
   mozilla::StyleTopLayer mTopLayer;
 
   mozilla::StyleTouchAction mTouchAction;

servo/components/style/properties/longhands/box.mako.rs

@@ -491,6 +491,7 @@ ${helpers.single_keyword(
     engines="gecko",
     spec="https://drafts.fxtf.org/compositing/#isolation",
     flags="CREATES_STACKING_CONTEXT",
+    gecko_enum_prefix="StyleIsolation",
     animation_value_type="discrete",
 )}