Skip to content

Commit e8a3072

Browse files
committed
Made requested changes to pin and unpin selected tabs test
1 parent 61dd689 commit e8a3072

File tree

2 files changed

+20
-25
lines changed

2 files changed

+20
-25
lines changed

modules/browser_object_tabbar.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -328,7 +328,7 @@ def verify_tab_focus_cycle(self, num_tabs: int):
328328
)
329329

330330
@BasePage.context_chrome
331-
def select_tabs_by_indices(
331+
def select_multiple_tabs_by_indices(
332332
self, indices: list[int], sys_platform: str
333333
) -> list[WebElement]:
334334
"""

tests/tabs/test_pin_unpin_selected_tabs.py

Lines changed: 19 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -30,27 +30,22 @@ def test_pin_unpin_selected_tabs(driver: Firefox, sys_platform: str):
3030
driver.get(URLS[i])
3131
assert len(driver.window_handles) == 5
3232

33-
with driver.context(driver.CONTEXT_CHROME):
34-
select_indices = [1, 3, 5]
35-
selected_tabs = tabs.select_tabs_by_indices(select_indices, sys_platform)
36-
tab_context_menu = ContextMenu(driver)
37-
38-
# Pin
39-
tab_context_menu.context_click(selected_tabs[1])
40-
tab_context_menu.click_and_hide_menu(
41-
("css selector", "#context_pinSelectedTabs")
42-
)
43-
44-
# Verify pinned
45-
for tab in selected_tabs:
46-
assert tabs.is_pinned(tab)
47-
48-
# Unpin
49-
tab_context_menu.context_click(selected_tabs[1])
50-
tab_context_menu.click_and_hide_menu(
51-
("css selector", "#context_unpinSelectedTabs")
52-
)
53-
54-
# Verify unpinned
55-
for tab in selected_tabs:
56-
assert not tabs.is_pinned(tab)
33+
select_indices = [1, 3, 5]
34+
selected_tabs = tabs.select_multiple_tabs_by_indices(select_indices, sys_platform)
35+
tab_context_menu = ContextMenu(driver)
36+
37+
# Pin
38+
tab_context_menu.context_click(selected_tabs[1])
39+
tab_context_menu.click_and_hide_menu(("css selector", "#context_pinSelectedTabs"))
40+
41+
# Verify pinned
42+
for tab in selected_tabs:
43+
assert tabs.is_pinned(tab)
44+
45+
# Unpin
46+
tab_context_menu.context_click(selected_tabs[1])
47+
tab_context_menu.click_and_hide_menu(("css selector", "#context_unpinSelectedTabs"))
48+
49+
# Verify unpinned
50+
for tab in selected_tabs:
51+
assert not tabs.is_pinned(tab)

0 commit comments

Comments
 (0)