test: Created test to verify selected tabs can be pinned/unpinned

Author: ruhankiani

modules/browser_object_tabbar.py

@@ -326,3 +326,41 @@ def verify_tab_focus_cycle(self, num_tabs: int):
             self.custom_wait(timeout=3).until(
                 lambda d: target_tab.get_attribute("visuallyselected") == ""
             )
+
+    @BasePage.context_chrome
+    def select_tabs_by_indices(
+        self, indices: list[int], sys_platform: str
+    ) -> list[WebElement]:
+        """
+        Selects multiple tabs based on their indices and returns list of tabs.
+
+        Preconditions:
+            - len(indices) > 1
+            - max(indices) < number of open tabs
+            - min(indices) >= 1
+        Notes:
+            - Opens (clicks) the tab at the first index in indices
+            - the first tab in the window is denoted by index 1 (1-based indexing)
+        """
+
+        start_tab = self.get_tab(indices[0])
+        selected_tabs = [start_tab]
+        start_tab.click()
+
+        actions = self.actions
+        if sys_platform == "Darwin":
+            actions.key_down(Keys.COMMAND).perform()
+        else:
+            actions.key_down(Keys.CONTROL).perform()
+
+        for i in range(1, len(indices)):
+            tab = self.get_tab(indices[i])
+            actions.click(tab).perform()
+            selected_tabs.append(tab)
+
+        if sys_platform == "Darwin":
+            actions.key_up(Keys.COMMAND).perform()
+        else:
+            actions.key_up(Keys.CONTROL).perform()
+
+        return selected_tabs

tests/reader_view/test_improved_type_control_panel.py

@@ -1,6 +1,6 @@
-import pytest
 from typing import Literal
 
+import pytest
 from selenium.webdriver import Firefox
 
 from modules.browser_object import ReaderView
@@ -25,8 +25,16 @@ def test_case() -> str:
 SliderDirection = Literal["decrease", "increase"]
 
 SIZE_CONTROLS: list[SizeControl] = ["minus", "plus"]
-FONTS: list[Literal["sans-serif", "serif", "monospace"]] = ["sans-serif", "serif", "monospace"]
-ALIGNMENTS: list[tuple[AlignKey, AlignCSS]] = [("left", "start"), ("right", "right"), ("center", "center")]
+FONTS: list[Literal["sans-serif", "serif", "monospace"]] = [
+    "sans-serif",
+    "serif",
+    "monospace",
+]
+ALIGNMENTS: list[tuple[AlignKey, AlignCSS]] = [
+    ("left", "start"),
+    ("right", "right"),
+    ("center", "center"),
+]
 SLIDER_DIRS: list[SliderDirection] = ["decrease", "increase"]
 
 
@@ -49,7 +57,9 @@ def _css_int(util: Utilities, element, prop: str) -> int:
 
 @pytest.mark.ci
 @pytest.mark.parametrize("font", FONTS)
-def test_type_control_panel_font(driver: Firefox, font: Literal["sans-serif", "serif", "monospace"]) -> None:
+def test_type_control_panel_font(
+    driver: Firefox, font: Literal["sans-serif", "serif", "monospace"]
+) -> None:
     """
     C130919.1: Ensure the functionality of the type control panels works (font family).
     """
@@ -61,10 +71,14 @@ def test_type_control_panel_font(driver: Firefox, font: Literal["sans-serif", "s
     body = web_page.get_element("page-body")
 
     # Ensure default is sans-serif first so the next wait has a stable baseline
-    reader_view.wait.until(lambda _: "sans-serif" in body.value_of_css_property("font-family"))
+    reader_view.wait.until(
+        lambda _: "sans-serif" in body.value_of_css_property("font-family")
+    )
 
     font_dropdown_root = reader_view.get_element("toolbar-font-selector")
-    font_dropdown = Dropdown(page=reader_view, require_shadow=False, root=font_dropdown_root)
+    font_dropdown = Dropdown(
+        page=reader_view, require_shadow=False, root=font_dropdown_root
+    )
     font_dropdown.select_option(
         f"about-reader-font-type-{font}",
         option_tag="option",
@@ -91,16 +105,20 @@ def test_type_control_panel_size(driver: Firefox, control: SizeControl) -> None:
     reader_view.get_element(f"toolbar-textsize-{control}").click()
 
     if control == "minus":
-        reader_view.wait.until(lambda _: _css_int(util, body, "--font-size") < size_before)
+        reader_view.wait.until(
+            lambda _: _css_int(util, body, "--font-size") < size_before
+        )
     else:
-        reader_view.wait.until(lambda _: _css_int(util, body, "--font-size") > size_before)
+        reader_view.wait.until(
+            lambda _: _css_int(util, body, "--font-size") > size_before
+        )
 
 
 @pytest.mark.parametrize("alignment,intended_alignment", ALIGNMENTS)
 def test_type_control_panel_text_alignment(
-        driver: Firefox,
-        alignment: AlignKey,
-        intended_alignment: AlignCSS,
+    driver: Firefox,
+    alignment: AlignKey,
+    intended_alignment: AlignCSS,
 ) -> None:
     """
     C130919.3: Ensure the functionality of the type control panels works (text alignment).
@@ -114,11 +132,16 @@ def test_type_control_panel_text_alignment(
     reader_view.open_advanced_options()
 
     reader_view.get_element(f"toolbar-text-align-{alignment}").click()
-    reader_view.wait.until(lambda _: container.value_of_css_property("--text-alignment") == intended_alignment)
+    reader_view.wait.until(
+        lambda _: container.value_of_css_property("--text-alignment")
+        == intended_alignment
+    )
 
 
 @pytest.mark.parametrize("direction", SLIDER_DIRS)
-def test_type_control_panel_content_width(driver: Firefox, direction: SliderDirection) -> None:
+def test_type_control_panel_content_width(
+    driver: Firefox, direction: SliderDirection
+) -> None:
     """
     C130919.4: Ensure the functionality of the type control panels works (content width slider).
     """
@@ -137,13 +160,19 @@ def test_type_control_panel_content_width(driver: Firefox, direction: SliderDire
     reader_view.change_slider_value(slider, increase=(direction == "increase"))
 
     if direction == "decrease":
-        reader_view.wait.until(lambda _: _css_int(util, body, "--content-width") < width_before)
+        reader_view.wait.until(
+            lambda _: _css_int(util, body, "--content-width") < width_before
+        )
     else:
-        reader_view.wait.until(lambda _: _css_int(util, body, "--content-width") > width_before)
+        reader_view.wait.until(
+            lambda _: _css_int(util, body, "--content-width") > width_before
+        )
 
 
 @pytest.mark.parametrize("direction", SLIDER_DIRS)
-def test_type_control_panel_line_spacing(driver: Firefox, direction: SliderDirection) -> None:
+def test_type_control_panel_line_spacing(
+    driver: Firefox, direction: SliderDirection
+) -> None:
     """
     C130919.5: Ensure the functionality of the type control panels works (line spacing slider).
     """
@@ -162,9 +191,13 @@ def test_type_control_panel_line_spacing(driver: Firefox, direction: SliderDirec
     reader_view.change_slider_value(slider, increase=(direction == "increase"))
 
     if direction == "decrease":
-        reader_view.wait.until(lambda _: _css_int(util, body, "block-size") < block_before)
+        reader_view.wait.until(
+            lambda _: _css_int(util, body, "block-size") < block_before
+        )
     else:
-        reader_view.wait.until(lambda _: _css_int(util, body, "block-size") > block_before)
+        reader_view.wait.until(
+            lambda _: _css_int(util, body, "block-size") > block_before
+        )
 
 
 def test_type_control_panel_character_spacing(driver: Firefox) -> None:
@@ -186,7 +219,9 @@ def test_type_control_panel_character_spacing(driver: Firefox) -> None:
 
     reader_view.change_slider_value(slider, increase=True)
 
-    reader_view.wait.until(lambda _: _css_int(util, container, "--letter-spacing") > letter_before)
+    reader_view.wait.until(
+        lambda _: _css_int(util, container, "--letter-spacing") > letter_before
+    )
 
 
 def test_type_control_panel_word_spacing(driver: Firefox) -> None:
@@ -208,4 +243,6 @@ def test_type_control_panel_word_spacing(driver: Firefox) -> None:
 
     reader_view.change_slider_value(slider, increase=True)
 
-    reader_view.wait.until(lambda _: _css_int(util, container, "--word-spacing") > word_before)
+    reader_view.wait.until(
+        lambda _: _css_int(util, container, "--word-spacing") > word_before
+    )

tests/tabs/test_pin_unpin_selected_tabs.py

@@ -0,0 +1,56 @@
+import pytest
+from selenium.webdriver import Firefox
+
+from modules.browser_object import ContextMenu, TabBar
+
+
+@pytest.fixture()
+def test_case():
+    return "246978"
+
+
+URLS = [
+    "about:about",
+    "about:addons",
+    "about:cache",
+    "about:robots",
+]
+
+
+def test_pin_unpin_selected_tabs(driver: Firefox, sys_platform: str):
+    """
+    C246978 - Verify that multiple tabs can be selected and pinned/unpinned from the context menu.
+    """
+
+    tabs = TabBar(driver)
+    # Create 4 new tabs
+    for i in range(4):
+        tabs.new_tab_by_button()
+        driver.switch_to.window(driver.window_handles[-1])
+        driver.get(URLS[i])
+    assert len(driver.window_handles) == 5
+
+    with driver.context(driver.CONTEXT_CHROME):
+        select_indices = [1, 3, 5]
+        selected_tabs = tabs.select_tabs_by_indices(select_indices, sys_platform)
+        tab_context_menu = ContextMenu(driver)
+
+        # Pin
+        tab_context_menu.context_click(selected_tabs[1])
+        tab_context_menu.click_and_hide_menu(
+            ("css selector", "#context_pinSelectedTabs")
+        )
+
+        # Verify pinned
+        for tab in selected_tabs:
+            assert tabs.is_pinned(tab)
+
+        # Unpin
+        tab_context_menu.context_click(selected_tabs[1])
+        tab_context_menu.click_and_hide_menu(
+            ("css selector", "#context_unpinSelectedTabs")
+        )
+
+        # Verify unpinned
+        for tab in selected_tabs:
+            assert not tabs.is_pinned(tab)