Skip to content

[DOC] add source code to rendered docs #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hwine opened this issue Oct 10, 2020 · 5 comments · Fixed by #390
Closed

[DOC] add source code to rendered docs #389

hwine opened this issue Oct 10, 2020 · 5 comments · Fixed by #390
Assignees

Comments

@hwine
Copy link
Contributor

hwine commented Oct 10, 2020

This would help during test development and selection. (Related to #387.)

Figure the "best" way to utilize Sphinx extensions to include the display the way we prefer. If folks have ideas about how that code should be laid out, please leave it below.

@hwine
Copy link
Contributor Author

hwine commented Oct 12, 2020

One choice we have is "How should the source entries appear in the table of contents?"

  • link to source-by-section (e.g. frost, aws, ...) on main ToC
  • Just link to a source sub-section, where each section has it's own links
  • Differentiate between "tests" and "support code" (client.py, conftest.py) under the assumption that frost users don't need to know about those. (Should be possible, but I'm currently having trouble with the config)
  • put support code under a "contributing/development" section.

I'll be experimenting with these on my doc test site - ping me on slack if you want a choice added, or done sooner.

@sciurus
Copy link
Contributor

sciurus commented Oct 12, 2020

It's a little hard to visualize just based on the descriptions- can you screenshot some different options?

@hwine
Copy link
Contributor Author

hwine commented Oct 12, 2020

It's a little hard to visualize just based on the descriptions- can you screenshot some different options?

Even better -- I'll (slowly) get all the options "live" on the test site, as I think clicking may be needed to make the best decision.

My intent was just to get folks thinking about things at this point, and solicit options I haven't thought of. I'll flag the PR for review by everyone when all the choices are up.

@hwine
Copy link
Contributor Author

hwine commented Oct 16, 2020

"test site" is up at https://hwine.github.io/frost/ -- there are some serious challenges:

  • much of the test_*.py does not render cleanly using sphinx-apidoc, as the modules do not import cleanly in the context of building the docs.
  • that might be helped by switching to the "autodoc" mode, which parses instead of importing
    • "autodoc" would make "extraction of just tests" harder, as we'd have to write a filter function

My gut feel is that we should abandon the options, and do the simplest thing-that-works for now. If other SRE teams want to use frost, the investment in "better" may be warranted.

vote by reaction, please: @ajvb @g-k @sciurus @Micheletto and anyone else. [this approach abandoned, as requiring too much customization at this time.]

@hwine hwine self-assigned this Oct 16, 2020
@hwine hwine added the decision needed stalled for now label Oct 16, 2020
@hwine
Copy link
Contributor Author

hwine commented Oct 22, 2020

We'll finalize api-docs-for-now in the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants