Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate that outcomes are for the correct application #9505

Closed
mikewilli opened this issue Sep 27, 2023 · 2 comments · Fixed by #10449
Closed

Validate that outcomes are for the correct application #9505

mikewilli opened this issue Sep 27, 2023 · 2 comments · Fixed by #10449

Comments

@mikewilli
Copy link
Contributor

mikewilli commented Sep 27, 2023 •
edited by data-sync-user
Loading

There was a recent experiment on Firefox for iOS that appears to be using a Fenix outcome. I'm not sure if this is accurate or just a UI issue, but we should investigate and confirm that experiments can't be configured with outcomes that don't match the application of the experiment.

┆Issue is synchronized with this Jira Task
@mikewilli
Copy link
Contributor Author

See mozilla/jetstream#1948 also for the Jetstream side of this same issue.

@mikewilli mikewilli mentioned this issue Mar 21, 2024
Merged
@mikewilli
Copy link
Contributor Author

This was a UI issue, and should be fixed on the Results page now. Some logic was added in #10441 to ensure that the UI is referencing the correct application in addition to the outcome slug.

Additionally, it looks fixed on the Summary page for the linked experiment, but I created a PR to ensure that the summary page filters by experiment application too (the same way the Results page was fixed).

github-merge-queue bot pushed a commit that referenced this issue Mar 22, 2024
@mikewilli
bug(nimbus): fix outcome slug lookup to filter by app (#10449)
ae5ff5e 
Because

- there can be overlaps in outcome slugs across applications
- we saw some experiment summary pages linking to the wrong
application's outcome definitions

This commit

- ensures that the outcomes hook filters to the experiment's application

Fixes #9505
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bug(nimbus): fix outcome slug lookup to filter by app mikewilli-moz/experimenter
1 participant
@mikewilli