Merge pull request #1131 from garvankeeley/github-acra-default-to-on

crankycoder · crankycoder · commit 1f0d954c8a13 · 2014-10-27T22:10:16.000-04:00
Default the ACRA reporting to on for github builds
diff --git a/android/src/main/java/org/mozilla/mozstumbler/client/ClientPrefs.java b/android/src/main/java/org/mozilla/mozstumbler/client/ClientPrefs.java
@@ -3,6 +3,7 @@
 import android.content.Context;
 import android.content.SharedPreferences;
 
+import org.mozilla.mozstumbler.BuildConfig;
 import org.mozilla.mozstumbler.service.Prefs;
 import org.mozilla.osmdroid.api.IGeoPoint;
 import org.mozilla.osmdroid.util.GeoPoint;
@@ -96,7 +97,8 @@ public void setCrashReportingEnabled(boolean b) {
     }
 
     public boolean isCrashReportingEnabled() {
-        return getBoolPrefWithDefault(CRASH_REPORTING, false);
+        // default to true for GITHUB build
+        return getBoolPrefWithDefault(CRASH_REPORTING, BuildConfig.GITHUB);
     }
 
     public void setMapTileResolutionType(int mapTileResolutionType) {

Original file line number	Diff line number	Diff line change
`@@ -3,6 +3,7 @@`
`3`	`3`	`import android.content.Context;`
`4`	`4`	`import android.content.SharedPreferences;`
`5`	`5`
	`6`	`+import org.mozilla.mozstumbler.BuildConfig;`
`6`	`7`	`import org.mozilla.mozstumbler.service.Prefs;`
`7`	`8`	`import org.mozilla.osmdroid.api.IGeoPoint;`
`8`	`9`	`import org.mozilla.osmdroid.util.GeoPoint;`
`@@ -96,7 +97,8 @@ public void setCrashReportingEnabled(boolean b) {`
`96`	`97`	`}`
`97`	`98`
`98`	`99`	`public boolean isCrashReportingEnabled() {`
`99`		`- return getBoolPrefWithDefault(CRASH_REPORTING, false);`
	`100`	`+ // default to true for GITHUB build`
	`101`	`+ return getBoolPrefWithDefault(CRASH_REPORTING, BuildConfig.GITHUB);`
`100`	`102`	`}`
`101`	`103`
`102`	`104`	`public void setMapTileResolutionType(int mapTileResolutionType) {`