Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure entity key only exists once in the entitylist #16

Open
groovecoder opened this issue Aug 15, 2016 · 2 comments
Open

Ensure entity key only exists once in the entitylist #16

groovecoder opened this issue Aug 15, 2016 · 2 comments

Comments

@groovecoder
Copy link
Contributor

groovecoder commented Aug 15, 2016

While processing the entity list, ensure that each property & resource domain only occurs in a single entity, to prevent down-stream bugs where a duplicate resource domain might be mis-identified as belonging to an entity.

See mozilla/blok#104 (comment)

groovecoder added a commit that referenced this issue Aug 25, 2016
for #16: check duplicate entities in json_verify
@groovecoder
Copy link
Contributor Author

Also need to ensure there are no duplicate keys like

"Adsrevenue": {
"properties": [
"adsrevenue.net"
],
"resources": [
"adsrevenue.net"
]
},
"Adsrevenue": {
"properties": [
"adsnative.com"
],
"resources": [
"adsnative.com"
]
},
.

@groovecoder groovecoder changed the title Ensure property and resource hosts only appear in a single domain Ensure entity key only exists once in the entitylist Oct 3, 2017
@groovecoder
Copy link
Contributor Author

Updated the title here since the first check (for duplicate domains) was done in 7387ebb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant