Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve AMO multimatch heuristic #514

Closed
kkleemola opened this issue Feb 1, 2021 · 0 comments · Fixed by #515
Closed

Improve AMO multimatch heuristic #514

kkleemola opened this issue Feb 1, 2021 · 0 comments · Fixed by #515

Comments

@kkleemola
Copy link
Contributor

This heuristic is a bit too simplistic and has caused false positives.
Modify AddonMultiMatch to instead use the shasum instead of file name. This is being added to the log statement. See.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use file hash instead of name for amo multimatch mozilla-services/foxsec-pipeline
1 participant
@kkleemola