New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create shared helper for reading config files from gcs #378

Closed

kkleemola opened this issue Apr 15, 2020 · 1 comment · Fixed by #380

Assignees

Contributor

kkleemola commented Apr 15, 2020

Refactor pattern for reading file from gcs or resource path into a helper that can be used everytime we need to do this.

kkleemola self-assigned this

ameihm0912 commented Apr 15, 2020

@kkleemola we have this here:

https://github.com/mozilla-services/foxsec-pipeline/blob/097a431054dd27188ebcc6d6a5ab3edf87a8417b/src/main/java/com/mozilla/secops/FileUtil.java

That will always return an ArrayList though, so maybe something a bit more generic is needed to cover all possible cases.

kkleemola mentioned this issue

refactor file util #380

Merged

ameihm0912 closed this as completed in #380

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment