Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support initialization of DetectNat with static address list #373

Closed
ameihm0912 opened this issue Apr 9, 2020 · 0 comments · Fixed by #376
Closed

Support initialization of DetectNat with static address list #373

ameihm0912 opened this issue Apr 9, 2020 · 0 comments · Fixed by #376
Assignees

Comments

@ameihm0912
Copy link

Currently DetectNat dynamically produces a side input as a materialized map based in ongoing analysis.

It should be modified so it can be optionally initialized with a static list of addresses, which will always be considered gateways by transforms that make use of NAT detection.

It would be good to just load this from GCS so a pattern like we use with identity manager could work, and the input option would be this path and the file would contain a list of addresses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants