Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve AMO cloud submission alert summary #371

Closed
ameihm0912 opened this issue Apr 9, 2020 · 1 comment
Closed

Improve AMO cloud submission alert summary #371

ameihm0912 opened this issue Apr 9, 2020 · 1 comment
Assignees

Comments

@ameihm0912
Copy link

Improve summary to include add-on GUID

Depends on mozilla/addons#7446

@diox
Copy link

diox commented Apr 16, 2020

mozilla/addons#7446 is now live in production.

This means, you can use the following log message to detect submissions:
'New version: %r (%s) from %r' % (version, version.id, upload)

With:

  • version (string, representation of the version object uploaded. Should look like <Version: %s>, where %s is the version number)
  • version.id (integer version ID in the versions table)
  • upload (string, representation of the File Upload uploaded. Should look like <FileUpload: %s> where %s is the upload UUID)

More importantly for foxsec pipeline, the following extra fields are present:

  • email (string user email)
  • user_id (integer user ID in the users table)
  • guid (string extension identifier)
  • from_api (boolean indicating whether or not the upload was made using the API)
  • uid (string username in the users table, but do not use it, it's not currently reliable for this particular situation. It's likely to always contain <anon> for API requests at this time)
  • remoteAddressChain (string IP address used by submission request)

For reference, the old log you are currently using if I'm not mistaken is:
'UPLOAD: %r (%s bytes) to %r' % (filename, size, loc) with email as the extra field being sent.

Unless you do something with the parameters that log sends, I'd suggest you stop using it and use the one I've described above. If you are using those parameters for something, let me know and I can look into adding them as well, though I don't think they are particularly relevant (logging the addon guid is much more useful to us to find them afterwards).

@ameihm0912 ameihm0912 self-assigned this Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants