Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use event timestamps everywhere #359

Open
ajvb opened this issue Apr 6, 2020 · 0 comments
Open

Use event timestamps everywhere #359

ajvb opened this issue Apr 6, 2020 · 0 comments

Comments

@ajvb
Copy link
Contributor

ajvb commented Apr 6, 2020

Within our parsing logic, we make use of the pubsub timestamp rather than the parsed events timestamp (Parser.stripStackdriverEncapsulation). This creates problems in the case of old messages getting backfilled into pubsub for whatever reason and causes a disconnect between our tests and production.

Instead, we should make use of the parsed out event timestamp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant