Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy notification support #829

Open
data-sync-user opened this issue Jan 22, 2025 · 0 comments
Open

Remove legacy notification support #829

data-sync-user opened this issue Jan 22, 2025 · 0 comments

Comments

@data-sync-user
Copy link
Collaborator

data-sync-user commented Jan 22, 2025

parse_chidmessageid includes old code paths for parsing legacy notification chidmessageid formats. This along with similar code in autoush-common’s Notification::chidmessageid and RangeKey::legacy_version should be removed as we no longer support these types of notifications.

Alongside the removal from Notification I think this struct could further enforce topic vs timestamp messages (without the need to support legacy types) by converting the topic and sortkey_timestamp fields into an enum:

struct Notification {
    ...
    ntype: NotificationType,
}

enum NotificationType {
    Topic(String),
    Timestamp(u64),
}

┆Issue is synchronized with this Jira Task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant