fixed search bug, added Teaser text field

Fixed bug with small search
Fixed bug with blog teasers - added new teaser db field
Added ability to change max comment size
added 404 error handler
Added new rows to 2 databases, requires alter table statements in order
to upgrade existing tables!

Author: mox1

app.py

@@ -23,7 +23,7 @@
 import model as m
 import hashlib
 
-VERSION = "0.9.5-BETA"
+VERSION = "0.9.6-BETA"
 
 logger.info("You are running version %s" % VERSION)
 
@@ -61,18 +61,19 @@
 
 def update_db():
     global t_globals
-    logger.debug("Start updating blog data")
+    logger.info("Start updating blog data")
     m.BlogData.update_stats()
-    logger.debug("Finish updating blog data")
+    logger.info("Finish updating blog data")
 
 
 #this function allows us to do periodic things
 #not perfect, but eh. 
 #for now this simply updates the statistics
 #but could easily be used to do more "cron" like things
+#this gets called for EVERY page, so don't do any heavy lifting
 next_cron_run = 0
 def my_processor(handler): 
-    global next_cron_run,td_next
+    global next_cron_run
     if (time.time() > next_cron_run):
         logger.debug("DOING CRON RUN")
         thr = threading.Thread(target=update_db)
@@ -148,7 +149,7 @@ def blog_data(update = False):
 t_globals["dt_as_ago"] = m.datetime_ago
 t_globals["hashlib"] = hashlib
 t_globals["csrf_token"] = csrf_token
-
+t_globals["max_comment"] = config.MAX_COMMENT
 
 #get statistics
 #This is now updated in the Admin class, method globalsettings
@@ -379,14 +380,14 @@ def GET(self):
         query = websafe(data["q"])
         #short querys are a heachache, lets avoid them
         if len(query) < 3:
-            flash("error","Search string \"%s\" is too short." % q)
+            flash("error","Search string \"%s\" is too short." % query)
             return web.seeother(urls[0])
         prev,next = calcprevnext(data)
         #if we drop in here, qo query
         posts = m.Post.search(query,page=next,max=10)
         content = render.blog_teasers(posts,"search?q=%s&n=%s" % (query,(prev-1)),
                                             "search?q=%s&n=%s" % (query,(next+1)))
-        return render.index("Search results for %s" % query, content, "Search Results",query)
+        return render.index("Search results for \"%s\"" % query, content, "Search Results","\"%s\""% query)
 
 class IndexFull:
     def GET(self):
@@ -472,15 +473,15 @@ def POST(self):
             print "New comment SPAM test failed by %s" % ip 
             return web.seeother(url[0])
 
-        postid = websafe(int(data.get("pid",-1)))
+        postid = websafe(int(data.get("pid","-1")))
         text = websafe(data.get("message",None))
-        if text == None:
+        if text == None or len(text) < 1:
             flash("error","Please add some text to that comment!")
             #TODO: can we use web.py to get the url referrer and send them back there?
-            return web.seeother("post?pid=%d" % postid)
+            return web.seeother("post?pid=%s" % postid)
         if len(text) > config.MAX_COMMENT:
-            flash("error","Comment too large, max %d characters" % config.MAX_COMMENT)
-            return web.seeother("post?pid=%d" % postid)
+            flash("error","Comment length of %d too large, max %d characters" % (len(text),config.MAX_COMMENT))
+            return web.seeother("post?pid=%s" % postid)
 
 
         #spam check passed, continue
@@ -525,13 +526,21 @@ def calcprevnext(data):
 def internalerror():
     logger.error("Internal error:",exc_info=True)
     msg = """
-    An internal server error occurred. Please try your request again by
+    We're sorry, an internal error occurred has. Please try your request again by
     hitting back on your web browser. You can also <a href="/"> go back
      to the main page.</a>
     """
     return web.internalerror(msg)
 
-
+def notfound():
+    logger.error("404 Not found error has occurred")
+    #return the homepage with not found
+    
+    return web.notfound(render.fullpageindex("404 Error Not Found","<p>404 Error: The page you have requested was not found!</p>",""))
+ 
+#add our 404 handler
+app.notfound = notfound 
+   
 # Setup the application's error handler
 app.internalerror = web.debugerror if web.config.debug else internalerror
 

config.py

@@ -14,9 +14,10 @@
 TIME_FORMAT = "%a, %d %b %Y" # %H:%M:%S
 #double %% required
 LONG_TIME_FORMAT = "%%A, %%b %s %%Y"
+#The Database limit for this field is 16656, values larger than that will error out.
 MAX_COMMENT = 4096
 #how often to update stats (in seconds)
-STAT_UPDATES = 60 * 60
+STAT_UPDATES = 60 * 60 #every hour by default
 ####END USER EDITABLE####
 
 valid_upload_ext = [".png",".jpg",".jpeg",".gif",".ico"]

model.py

@@ -152,6 +152,8 @@ class User(BaseModel):
     crypted_password = pw.CharField(max_length=40, null=False)
     salt = pw.CharField(max_length=40, null=False)
     remember_token = pw.CharField(max_length=64, null=True)
+    #for future use
+    sm_links = pw.TextField(null=True)
 
     @staticmethod
     def is_setup():
@@ -298,6 +300,7 @@ class Post(BaseModel):
     #1 = moderated (admin must approve comments)
     #2 = disabled (no new comments allowed)
     moderate = pw.IntegerField(null=False,default=0)
+    teaser_txt = pw.TextField(null=False)
 
     #data is web.input, mapping is
     # title = data.nptitle
@@ -322,6 +325,7 @@ def update_from_input(data,userid):
             tags = data["uptags"]
             cat = data["upcat"]
             scat = data["upsubcat"]
+            teaser_txt = data["uptease"]
             html = data["uphtml"]
             mod = int(data["upmod"])
             if data.get("upfav","false") == "true":
@@ -353,6 +357,7 @@ def update_from_input(data,userid):
         post.public = public
         post.updated = datetime.now()
         post.moderate = mod
+        post.teaser_txt = teaser_txt
         post.save()
         return (post,"Successfully updated post!")
 
@@ -442,6 +447,7 @@ def new_from_input(data,userid):
             cat = data["npcat"]
             scat = data["npsubcat"]
             html = data["nphtml"]
+            teaser_txt = data["nptease"]
             mod = int(data["npmod"])
             if data.get("npfav","false") == "true":
                 fav = True
@@ -459,17 +465,19 @@ def new_from_input(data,userid):
             return (None,"Sorry there was an error: %s" % e.message)
 
         post = Post.new(title=title,tags=tags,author_id=userid,image=image,
-                        small_image=small_image,html=html,cat=cat,subcat=scat,fav=fav,public=public,moderate=mod)
+                        small_image=small_image,html=html,cat=cat,subcat=scat,
+                        fav=fav,public=public,moderate=mod,teaser_txt=teaser_txt)
+        
         return (post,"Successfully created new post!")
 
 
     @staticmethod
-    def new(title,tags,author_id,html,image,small_image,cat=None,subcat=None,fav = False,public=True,moderate=0):
+    def new(title,tags,author_id,html,image,small_image,cat=None,subcat=None,fav=False,public=True,moderate=0,teaser_txt=""):
         #get user by id
         user = User.by_id(author_id)
         p = Post.create(title=title,tags=tags,author=user,html=html,
                         image=image,small_image=small_image,created_at=datetime.now(),
-                        favorite=fav,category=cat,subcategory=subcat,moderate=moderate)
+                        favorite=fav,category=cat,subcategory=subcat,moderate=moderate,teaser_txt=teaser_txt)
         return p
 
     #every time this is called, a pageview count is updated"
@@ -512,7 +520,7 @@ class Comment(BaseModel):
     ip = pw.CharField(max_length=20,null=True)
     post = pw.ForeignKeyField(Post,null=False)
     text = pw.TextField(max_length=16656,null=False)
-    email = pw.CharField(max_length=1024,null=False,default="[email protected]")
+    email = pw.CharField(max_length=512,null=False,default="[email protected]")
     parent = pw.ForeignKeyField('self',related_name='children',null=True)
     rank = pw.IntegerField(null=False,default=0)
     indent = pw.IntegerField(null=False,default=0)
@@ -608,11 +616,19 @@ def get_comments(postid,show_mod):
 
     @staticmethod
     def new(postid,parentid,title,author,text,email="[email protected]",admin=False,ip=None):
-        #1st get post, check if comments are allowed
+        #check for size violations
+        if (len(text) > config.MAX_COMMENT) or \
+           (len(text) < 1) or \
+           (len(email) > 512) or \
+           (len(author) > 512) or \
+           (len(title) > 512):
+            return None
+        
+        #2nd get post, check if comments are allowed
         post = Post.by_id(postid)
         if (post == None) or (post.moderate == 2):
             return None
-        #put this post into a "review by admin state"
+        #If moderation is turned on for this post,put this comment into a "review by admin state"
         if post.moderate ==1:
             status = 5
         else:
@@ -623,6 +639,8 @@ def new(postid,parentid,title,author,text,email="[email protected]",admin=False,ip=N
             status = 0
         #we need to convert \n into <br>
         text = newline_to_break(text)
+        #now, actually create and insert comment
+        ##see :http://evolt.org/node/4047/ for algorithm
         rank = 0
         indent = 0
         lastcomment = None
@@ -647,10 +665,10 @@ def new(postid,parentid,title,author,text,email="[email protected]",admin=False,ip=N
             new_comment = Comment.create(email=email,parent=parent,title=title,
                                          author=author,post=postid,text=text,rank=start_rank+1,indent=parent.indent+1,
                                          created_at=datetime.now(),from_admin=admin,status=status,ip=ip)
-            
-
             return new_comment
 
+
+
 #this class / table performs 2 function
 # 1. it is used as an optimization
 #    holding the results of other queries that rarely change

templates/add_comment.html

@@ -8,18 +8,20 @@ <h2><i class="icon-heart"></i> Add Comment</h2>
 			$if logged_in == False:
 				<div class="row">
 					<div class="col-md-6">
-						<input type="text" name="name" id="comment-name" placeholder="Name" class="form-control input-lg">
+						<input type="text" name="name" id="comment-name" placeholder="Name" class="form-control input-lg"
+							rel="tooltip" data-original-title="This will be shown as your username with this post. Minimum 3 characters."
+							pattern=".{3,}" title="At least 3 characters please.">
 					</div>
 					<div class="col-md-6">
-						<input type="email" name="e" id="comment-email" placeholder="Email" class="form-control input-lg">
+						<input type="email" name="e" id="comment-email" placeholder="Email" class="form-control input-lg"
+						rel="tooltip" data-original-title="This is only used to fetch your gravatar. It is *NOT* shown publically. Leave blank for a default gravatar.">
 					</div>
 				</div>
 			$else:
 				<p>You are logged in, your current username and e-mail will be used for this post.</p>
-	
 			<input type="text" name="title" id="input-comment-title" placeholder="Title..." class="form-control input-lg">
-			<textarea rows="10" name="message" id="comment-body" placeholder="Your thoughts..." class="form-control input-lg" maxlength="4096"></textarea>
-	
+			<p> HTML not allowed. Maximum length is $max_comment characters. </p>
+			<textarea rows="10" name="message" id="comment-body" placeholder="Your thoughts..." class="form-control input-lg" maxlength="$max_comment"></textarea>
 			<input type="hidden" name="pid" id="input-pid" value="$(cur_post.id)">
 			<input type="hidden" name="replyto" id="input-replyto" value="-1">
 			<input type="hidden" name="email" id="input-email" value="">

templates/admin.html

@@ -80,9 +80,17 @@ <h3 class="panel-title"> New Post </h3>
 										</div>
 										</div>
 										<div class="row">
+										<div class="col-md-12">
+											<label class="control-label" for="nptease">Leading Text / Teaser</label>
+											<textarea class="form-control" id="nptease" name="nptease" style="height: 100px: width: 100%;"
+											placeholder="A short description of this post. Displayed before showing the full blog post."></textarea>
+										</div>	
+										</div>
+										<div class="row">
 										<div class="col-md-12">
 											<label class="control-label" for="nphtml">Blog post/html:</label>
-											<textarea class="form-control" id="nphtml" name="nphtml" style="height: 300px; width:100%;" placeholder="Blog post goes here, HTML is allowed."> </textarea>
+											<textarea class="form-control" id="nphtml" name="nphtml" style="height: 300px; width:100%;" 
+											placeholder="Blog post goes here, HTML is allowed."></textarea>
 										</div>
 										</div>
 										<div class="row">

templates/adminsinglepost.html

@@ -53,6 +53,12 @@ <h4 class="modal-title" id="myModalLabel">Editing Post #$(post.id) - "$(post.tit
 			</div>
 			</div>
 			<div class="row">
+			<div class="col-md-12">
+				<label class="control-label" for="uptease">Leading Text / Teaser</label>
+				<textarea class="form-control" id="uptease" name="uptease" style="height: 100px: width: 100%;">$(post.teaser_txt)</textarea>
+			</div>	
+			</div>
+			<div class="row">
 			<div class="col-md-12">
 				<label class="control-label" for="uphtml">Blog post/html:</label>
 				<textarea class="form-control" id="uphtml" name="uphtml" style="height: 300px; width:100%;">$(post.html)</textarea>

templates/singleteaser.html

@@ -1,5 +1,4 @@
 $def with(blogpost)
-$ preview_text = blogpost.html[0:128] + "..."
 <div class="col-md-6 col-sm-6">
 	<article class=" blog-teaser">
 	    <header>
@@ -12,7 +11,7 @@ <h3><a href="/post?pid=$(blogpost.id)">$:(blogpost.title)</a></h3>
 	        <hr>
 	    </header>
 	    <div class="body">
-	    	$:preview_text
+	    	$:(blogpost.teaser_txt)
 	    </div>
 	    <div class="clearfix">
 	        <a href="/post?pid=$:(blogpost.id)" class="btn btn-tales-one">Read more</a>