Skip to content

Commit f4f0b53

Browse files
committed
build: fix docker steps for CI
1 parent c430aa7 commit f4f0b53

File tree

3 files changed

+23
-8
lines changed

3 files changed

+23
-8
lines changed

.github/workflows/go.yml

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -113,12 +113,21 @@ jobs:
113113
- name: Check out code into the Go module directory
114114
uses: actions/checkout@v5
115115

116-
- name: Docker Build
116+
- name: Docker Hub
117117
run: make docker-hub
118118

119-
- name: Build Image
119+
- name: Push Tagged Image
120+
run: |+
121+
echo "$DOCKER_PASSWORD" | docker login -u "$DOCKER_USERNAME" --password-stdin
122+
make release-push-tag
123+
env:
124+
DOCKER_USERNAME: ${{ secrets.DOCKER_USERNAME }}
125+
DOCKER_PASSWORD: ${{ secrets.DOCKER_PASSWORD }}
126+
127+
- name: Docker Static
120128
run: make docker-static
121129

130+
122131
openshift:
123132
name: Openshift Docker Build
124133
runs-on: ${{ matrix.os }}

.github/workflows/release.yml

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -157,17 +157,21 @@ jobs:
157157
- name: Docker Hub
158158
run: make docker-hub
159159

160-
- name: Docker Static
161-
run: make docker-static
162-
163-
- name: Docker Push
160+
- name: Push Tagged Image
164161
run: |+
165162
echo "$DOCKER_PASSWORD" | docker login -u "$DOCKER_USERNAME" --password-stdin
166-
make release-push
163+
make release-push-tag
167164
env:
168165
DOCKER_USERNAME: ${{ secrets.DOCKER_USERNAME }}
169166
DOCKER_PASSWORD: ${{ secrets.DOCKER_PASSWORD }}
170167

168+
- name: Docker Static
169+
run: make docker-static
170+
171+
- name: Docker Push Static Image
172+
run:
173+
make release-push-static
174+
171175
docker-openshift:
172176
name: Docker Openshift
173177
needs: [tests, create_release]

makefile

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -160,8 +160,10 @@ docker-openshift:
160160
docker-static:
161161
docker build --pull --build-arg VERSION=${VERSION} -t moov/watchman:static -f ./build/Dockerfile.static .
162162

163-
release-push:
163+
release-push-tag:
164164
docker push moov/watchman:${VERSION}
165+
166+
release-push-static:
165167
docker push moov/watchman:static
166168

167169
quay-push:

0 commit comments

Comments
 (0)