fix c++17 deprectaion of random_shuffle & update ci/cd to fail on windows when build fails

Author: SirJosh3917

.github/workflows/nightly_build.yml

@@ -75,7 +75,9 @@ jobs:
 
       - name: Build SFML
         if: steps.cache-sfml.outputs.cache-hit != 'true'
+        shell: bash
         run: |
+          set -e
           git clone https://github.com/SFML/SFML --depth 1
           pushd SFML
             cmake -B build -DSFML_USE_STATIC_STD_LIBS=TRUE -DBUILD_SHARED_LIBS=FALSE
@@ -88,7 +90,9 @@ jobs:
         uses: actions/[email protected]
 
       - name: Build Project
+        shell: bash
         run: |
+          set -e
           cmake -B build
           cmake --build build --config Release
           cmake --install build --config Release

src/SortingVisualizer/Collection.cpp

@@ -1,6 +1,7 @@
 
 #include <SortingVisualizer/Collection.hpp>
 #include <algorithm>
+#include <random>
 #include <stdint.h>
 #include <vector>
 
@@ -43,7 +44,7 @@ const uint64_t Collection::max() const { return *std::max_element(this->values.b
 
 std::vector<uint64_t> Collection::contents() const { return this->values; }
 
-void Collection::randomize() { std::random_shuffle(this->values.begin(), this->values.end()); }
+void Collection::randomize() { std::shuffle(this->values.begin(), this->values.end(), std::mt19937(std::random_device()())); }
 
 const std::vector<Decision> &Collection::getDecisions() const { return this->decisions; }