Overhaul TaglibSharp, lots of changes

* Bump version -> 2.2.0.0
* C#-ify
* Multitargeting - Target net462, netstandard 2.0
* Convert to new csproj files
* Update travis-ci
* Add appveyor
* Add .editorconfig and reformat code
  * Hopefully this'll result in fewer formatting issues in future PRs
* Update and improve autotools files
* Add raw-samples tests back
* Add Directory.Build.* to centralize some build values
* Add nupkg build to TaglibSharp project
* Remove old policy file
  * Since we are targeting net462 we can take advantage of the auto binding
     redirect feature that projects have available now.

Author: decriptor

.editorconfig

@@ -1,10 +1,90 @@
-# EditorConfig is awesome: http://EditorConfig.org
+# EditorConfig is awesome:http://EditorConfig.org
 
 # top-most EditorConfig file
 root = true
 
-# MediaPortal code style
+# Baseline
 [*]
+charset = utf-8
 indent_style = tab
-end_of_line = crlf
-insert_final_newline = true
+trim_trailing_whitespace = true
+max_line_length = 120
+
+# MSBuild
+[*.{csproj,proj,projitems,shproj,fsproj,target,props}]
+indent_style = space
+indent_size = 2
+
+# XML config files
+[*.{config,nuspec,resx}]
+indent_style = space
+indent_size = 2
+
+# JSON files
+[*.json]
+indent_style = space
+indent_size = 2
+
+# Dotnet code style settings:
+[*.{cs}]
+
+# Sort using and Import directives with System.* appearing first
+dotnet_sort_system_directives_first = true
+
+# Avoid "this." and "Me." if not necessary
+dotnet_style_qualification_for_field = false:suggestion
+dotnet_style_qualification_for_property = false:suggestion
+dotnet_style_qualification_for_method = false:suggestion
+dotnet_style_qualification_for_event = false:suggestion
+
+# Use language keywords instead of framework type names for type references
+dotnet_style_predefined_type_for_locals_parameters_members = true:suggestion
+dotnet_style_predefined_type_for_member_access = true:suggestion
+
+# Suggest more modern language features when available
+dotnet_style_object_initializer = true:suggestion
+dotnet_style_collection_initializer = true:suggestion
+dotnet_style_coalesce_expression = true:suggestion
+dotnet_style_null_propagation = true:suggestion
+dotnet_style_explicit_tuple_names = true:suggestion
+
+# CSharp code style settings:
+[*.cs]
+
+# spaces before parens
+csharp_space_between_method_declaration_name_and_open_parenthesis = true
+csharp_space_between_method_call_name_and_opening_parenthesis = true
+csharp_space_after_keywords_in_control_flow_statements = true
+
+# Newline settings
+csharp_new_line_before_open_brace = types,methods
+csharp_new_line_before_else = false
+csharp_new_line_before_catch = false
+csharp_new_line_before_finally = false
+csharp_new_line_before_members_in_object_initializers = true
+csharp_new_line_before_members_in_anonymous_types = true
+
+# Switch indentation
+csharp_indent_switch_labels = false
+
+# Prefer "var" everywhere it's apparent
+csharp_style_var_for_built_in_types = true:none
+csharp_style_var_when_type_is_apparent = true:suggestion
+csharp_style_var_elsewhere = true:none
+
+# Prefer method-like constructs to have a block body
+csharp_style_expression_bodied_methods = false:none
+csharp_style_expression_bodied_constructors = false:none
+csharp_style_expression_bodied_operators = false:none
+
+# Prefer property-like constructs to have an expression-body
+csharp_style_expression_bodied_properties = true:none
+csharp_style_expression_bodied_indexers = true:none
+csharp_style_expression_bodied_accessors = true:none
+
+# Suggest more modern language features when available
+csharp_style_pattern_matching_over_is_with_cast_check = true:suggestion
+csharp_style_pattern_matching_over_as_with_null_check = true:suggestion
+csharp_style_inlined_variable_declaration = true:suggestion
+csharp_style_throw_expression = true:suggestion
+csharp_style_conditional_delegate_call = true:suggestion

.gitignore

@@ -8,30 +8,22 @@ obj/
 config.log
 config.status
 configure
-*.exe
-*.mdb
-*.pdb
-*.pidb
 *.config
 install-sh
 missing
 *.pc
 *.zip
-tests/samples/tmp*
+*.dll
+*.pdb
+*.exe
 docs/*.xml
 docs/*/*
 docs/*.tree
-*.dll.xml
-examples/*.dll
 *.userprefs
-src/*.dll
-src/*.snk
-tests/*.dll
-tests/*.xml
-test-results
 .*.swp
 packages
-.vs/*
-!packages.config
+.vs
 .DS_Store
-src/taglib-sharp.XML
+TestResult.xml
+src/TaglibSharp.Tests/samples/tmp*
+*.sln.DotSettings.user

.gitmodules

@@ -0,0 +1,3 @@
+[submodule "src/TaglibSharp.Tests/raw-samples"]
+	path = src/TaglibSharp.Tests/raw-samples
+	url = https://github.com/f-spot/raw-samples.git

.travis.yml

@@ -1,8 +1,7 @@
 sudo: required
 dist: trusty
 language: csharp
-solution: taglib-sharp.sln
-dotnet: 2.1.4
+solution: TaglibSharp.sln
 mono: latest
 
 # https://github.com/travis-ci/travis-ci/issues/5932#issuecomment-215693171
@@ -13,12 +12,17 @@ before_install:
 
 install:
   - sudo apt-get update -qq > /dev/null
-  - mono .nuget/nuget.exe restore taglib-sharp.sln -Verbosity detailed
-  - mono .nuget/nuget.exe install NUnit.Runners -Version 3.8.0 -OutputDirectory packages
-  - dotnet restore
+    #  - mono .nuget/nuget.exe restore TaglibSharp.sln -Verbosity detailed
+  - mono .nuget/nuget.exe install NUnit.Runners -Version 3.9.0 -OutputDirectory packages
 
 script:
   - ./autogen.sh
-  - msbuild taglib-sharp.sln
-  - cd tests
-  - mono ../packages/NUnit.ConsoleRunner.3.8.0/tools/nunit3-console.exe --labels=All tests.dll
+  - make
+  - make dist # Let's make sure we don't break make dist
+  - cd src/TaglibSharp.Tests/bin/Debug
+  - mono ../../../../packages/NUnit.ConsoleRunner.3.9.0/tools/nunit3-console.exe --labels=All net462/TaglibSharp.Tests.dll
+# This errors out for some reason:
+  # System.IO.FileNotFoundException: Unable to find tests for C:\code\taglib-sharp\src\TaglibSharp.Tests\bin\Debug\netstandard2.0\TaglibSharp.Tests.dll.
+  # Make sure test project has a nuget reference of package "Microsoft.NET.Test.Sdk" and framework version settings are appropriate.
+  # Rerun with /diag option to diagnose further.
+  #  - mono ../../../../packages/NUnit.ConsoleRunner.3.9.0/tools/nunit3-console.exe --labels=All netstandard2.0/TaglibSharp.Tests.dll

AUTHORS

@@ -1,5 +1,5 @@
 Maintainer:
-  Gabriel Burt <[email protected]>
+  Stephen Shaw
 
 Contributors:
   Aaron Bockover
@@ -36,3 +36,6 @@ Contributors:
 
 Creator, past maintainer:
   Brian Nickel <[email protected]>
+
+Past maintainers:
+  Gabriel Burt <[email protected]>

Directory.Build.props

@@ -0,0 +1,9 @@
+<Project>
+    <PropertyGroup>
+        <ReleaseVersion>2.2.0.0</ReleaseVersion>
+        <RepositoryUrl>https://github.com/mono/taglib-sharp</RepositoryUrl>
+        <RepositoryType>git</RepositoryType>
+        <TaglibSharpTargetFramework>net462;netstandard2.0</TaglibSharpTargetFramework>
+        <LangVersion>latest</LangVersion>
+    </PropertyGroup>
+</Project>

Directory.Build.targets

@@ -0,0 +1,3 @@
+<Project>
+
+</Project>

Makefile.am

@@ -1,25 +1,15 @@
 SUBDIRS = \
-   src    \
-   examples \
-   docs
-
-if !IN_DIST
-SUBDIRS += tests
-endif
-
-DIST_SUBDIRS = \
-   src    \
-   examples \
-   docs
+       	  src    \
+       	  examples \
+       	  docs
 
 pkgconfig_in_files = taglib-sharp.pc.in
 pkgconfigdir = $(datadir)/pkgconfig
 pkgconfig_DATA = $(pkgconfig_in_files:.pc.in=.pc)
 
 EXTRA_DIST =             \
    $(pkgconfig_in_files) \
-   taglib-sharp.snk \
-   taglib-sharp.sln
+   TaglibSharp.sln
 
 DISTCLEANFILES = taglib-sharp.pc
 
@@ -38,10 +28,13 @@ MAINTAINERCLEANFILES = \
 	config.guess \
 	mkinstalldirs
 
-if !IN_DIST
-test:
-	cd tests; make test; cd ..;
-endif
+
+all: sln_build
+	echo "Building TaglibSharp solution"
+
+test: all
+	nuget install NUnit.Runners -Version 3.9.0 -OutputDirectory packages
+	$(MONO) packages/NUnit.ConsoleRunner.3.9.0/tools/nunit3-console.exe --labels=All $(srcdir)/src/TaglibSharp.Tests/bin/Debug/$(TARGET_FRAMEWORK)/TaglibSharp.Tests.dll
 
 distwin: all
 	mkdir -p $(srcdir)/$(WINDIR)
@@ -57,19 +50,4 @@ distwin: all
 	zip -9 -r $(srcdir)/$(WINDIR).zip $(srcdir)/$(WINDIR)
 	rm -rf $(srcdir)/$(WINDIR)
 
-UPLOAD_HOST = "[email protected]"
-UPLOAD_PATH = "web/download.banshee.fm/taglib-sharp"
-push-release: distcheck distwin
-	[[ -z "$$BANSHEE_USER" ]] && { echo "Set BANSHEE_USER"; exit 1; } || true
-	mkdir -p release
-	mv $(WINDIR).zip release
-	mv $(PACKAGE)-$(VERSION).tar.* release
-	cp ChangeLog release/$(PACKAGE)-$(VERSION).changes
-	cp NEWS release/$(PACKAGE)-$(VERSION).news
-	pushd release; sha256sum * > $(PACKAGE)-$(VERSION).sha256sum; popd
-	scp -r release $(UPLOAD_HOST):$(UPLOAD_PATH)/$(VERSION)
-	rm -rf release
-	ssh $(UPLOAD_HOST) rm -f $(UPLOAD_PATH)/LATEST-IS\*
-	ssh $(UPLOAD_HOST) touch $(UPLOAD_PATH)/LATEST-IS-$(VERSION)
-	git tag -a -m "Tag for taglib-sharp release ${VERSION}" taglib-sharp-${VERSION} || bail "Could not create tag"
-	git push origin taglib-sharp-${VERSION} || bail "Failed to push tag to remote"
+include $(top_srcdir)/build/msbuild.include