full set of tests

Author: baileympearson

test/integration/server-discovery-and-monitoring/server_discovery_and_monitoring.prose.test.ts

@@ -12,6 +12,7 @@ import {
   SERVER_HEARTBEAT_FAILED,
   SERVER_HEARTBEAT_SUCCEEDED
 } from '../../../src/constants';
+import { sleep } from '../../tools/utils';
 
 describe('Server Discovery and Monitoring Prose Tests', function () {
   context('Monitors sleep at least minHeartbeatFrequencyMS between checks', function () {
@@ -194,28 +195,18 @@ describe('Server Discovery and Monitoring Prose Tests', function () {
 
   context('Connection Pool Backpressure', function () {
     let client: MongoClient;
-    let utilClient: MongoClient;
     const checkoutFailedEvents: Array<ConnectionCheckOutFailedEvent> = [];
     const poolClearedEvents: Array<ConnectionPoolClearedEvent> = [];
 
-    const metadata: MongoDBMetadataUI = {
-      requires: {
-        mongodb: '>=7.0'
-      }
-    };
-
     beforeEach(async function () {
-      client = this.configuration.newClient({}, { maxConnecting: 20 });
+      client = this.configuration.newClient({}, { maxConnecting: 100 });
 
       client.on('connectionCheckOutFailed', e => checkoutFailedEvents.push(e));
       client.on('connectionPoolCleared', e => poolClearedEvents.push(e));
 
       await client.connect();
 
-      utilClient = this.configuration.newClient();
-      await utilClient.connect();
-
-      const admin = utilClient.db('admin').admin();
+      const admin = client.db('admin').admin();
       await admin.command({
         setParameter: 1,
         ingressConnectionEstablishmentRateLimiterEnabled: true
@@ -233,41 +224,42 @@ describe('Server Discovery and Monitoring Prose Tests', function () {
         ingressConnectionEstablishmentMaxQueueDepth: 1
       });
 
-      await utilClient.db('test').collection('test').insertOne({});
+      await client.db('test').collection('test').insertOne({});
     });
 
     afterEach(async function () {
-      const admin = utilClient.db('admin').admin();
+      // give the time to recover from the connection storm before cleaning up.
+      await sleep(1000);
+
+      const admin = client.db('admin').admin();
       await admin.command({
         setParameter: 1,
         ingressConnectionEstablishmentRateLimiterEnabled: false
       });
 
-      await utilClient.close();
       await client.close();
     });
 
-    it('runs', metadata, async function () {
-      await Promise.allSettled(
-        Array.from({ length: 10 }).map(() =>
-          client
-            .db('test')
-            .collection('test')
-            .findOne({ $where: 'function() { sleep(2000); return true; }' })
-        )
-      );
-
-      await Promise.allSettled(
-        Array.from({ length: 100 }).map(() =>
-          client
-            .db('test')
-            .collection('test')
-            .findOne({ $where: 'function() { sleep(2000); return true; }' })
-        )
-      );
-
-      expect(poolClearedEvents).to.be.empty;
-      expect(checkoutFailedEvents.length).to.be.greaterThan(10);
-    });
+    it(
+      'does not clear the pool when connections are closed due to connection storms',
+      {
+        requires: {
+          mongodb: '>=7.0' // rate limiting added in 7.0
+        }
+      },
+      async function () {
+        await Promise.allSettled(
+          Array.from({ length: 100 }).map(() =>
+            client
+              .db('test')
+              .collection('test')
+              .findOne({ $where: 'function() { sleep(2000); return true; }' })
+          )
+        );
+
+        expect(poolClearedEvents).to.be.empty;
+        expect(checkoutFailedEvents.length).to.be.greaterThan(10);
+      }
+    );
   });
 });

test/integration/server-discovery-and-monitoring/server_discovery_and_monitoring.spec.test.ts

@@ -15,10 +15,6 @@ const skipTable: { pattern: string; reason: string }[] = [
   {
     pattern: 'connect with serverMonitoringMode=auto >=4.4',
     reason: 'TODO(NODE-6045): Ensure that first server hearbeat does not report that it is awaited'
-  },
-  {
-    pattern: 'Pool is not cleared on handshake error during minPoolSize ',
-    reason: 'broken'
   }
 ];
 

test/spec/server-discovery-and-monitoring/unified/backpressure-pool-no-clear-min-pool-size-error.json

@@ -32,10 +32,7 @@
                   "id": "client",
                   "observeEvents": [
                     "serverDescriptionChangedEvent",
-                    "connectionCreatedEvent",
-                    "poolClearedEvent",
-                    "connectionClosedEvent",
-                    "connectionReadyEvent"
+                    "connectionClosedEvent"
                   ],
                   "uriOptions": {
                     "appname": "authErrorTest",
@@ -96,23 +93,14 @@
       "expectEvents": [
         {
           "client": "client",
-          "eventType": "cmap",
+          "eventType": "sdam",
           "events": [
             {
-              "connectionCreatedEvent": {}
-            },
-            {
-              "connectionReadyEvent": {}
-            },
-            {
-              "connectionCreatedEvent": {}
-            },
-            {
-              "connectionClosedEvent": {}
+              "serverDescriptionChangedEvent": {}
             }
           ]
         }
       ]
     }
   ]
-}
+}