Skip to content

Commit 5e6638a

Browse files
test(NODE-6477): skip failing serverless tests (#4300)
1 parent 75a4f9a commit 5e6638a

File tree

8 files changed

+45
-14
lines changed

8 files changed

+45
-14
lines changed

.evergreen/run-serverless-tests.sh

+1
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ npx mocha \
2020
test/integration/sessions/sessions.prose.test.ts \
2121
test/integration/sessions/sessions.test.ts \
2222
test/integration/transactions/transactions.spec.test.ts \
23+
test/integration/transactions-convenient-api/transactions-convenient-api.spec.test.ts \
2324
test/integration/transactions/transactions.test.ts \
2425
test/integration/versioned-api/versioned_api.spec.test.ts \
2526
test/integration/load-balancers/load_balancers.spec.test.ts \

test/integration/transactions-convenient-api/transactions-convenient-api.spec.test.ts

-10
Original file line numberDiff line numberDiff line change
@@ -10,16 +10,6 @@ const SKIPPED_TESTS = [
1010
];
1111

1212
describe('Transactions Convenient API Spec Unified Tests', function () {
13-
beforeEach(function () {
14-
if (this.configuration.topologyType === 'LoadBalanced') {
15-
if (this.currentTest) {
16-
this.currentTest.skipReason =
17-
'TODO(NODE-5931) - Fix socket leaks in load balancer transaction tests.';
18-
}
19-
this.skip();
20-
}
21-
});
22-
2313
runUnifiedSuite(loadSpecTests(path.join('transactions-convenient-api', 'unified')), test => {
2414
return SKIPPED_TESTS.includes(test.description)
2515
? 'TODO(NODE-5855): Skipping failing transaction tests'

test/spec/transactions-convenient-api/unified/commit-retry.json

+6-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"description": "commit-retry",
3-
"schemaVersion": "1.3",
3+
"schemaVersion": "1.4",
44
"runOnRequirements": [
55
{
66
"minServerVersion": "4.0",
@@ -422,6 +422,11 @@
422422
},
423423
{
424424
"description": "commit is not retried after MaxTimeMSExpired error",
425+
"runOnRequirements": [
426+
{
427+
"serverless": "forbid"
428+
}
429+
],
425430
"operations": [
426431
{
427432
"name": "failPoint",

test/spec/transactions-convenient-api/unified/commit-retry.yml

+4-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
description: commit-retry
22

3-
schemaVersion: '1.3'
3+
schemaVersion: '1.4'
44

55
runOnRequirements:
66
- minServerVersion: '4.0'
@@ -212,6 +212,9 @@ tests:
212212
- { _id: 1 }
213213
-
214214
description: commit is not retried after MaxTimeMSExpired error
215+
runOnRequirements:
216+
# Serverless sets empty `codeName` on failpoint errors. Remove once CLOUDP-280424 is fixed.
217+
- serverless: forbid
215218
operations:
216219
- name: failPoint
217220
object: testRunner

test/spec/transactions-convenient-api/unified/commit-writeconcernerror.json

+16-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"description": "commit-writeconcernerror",
3-
"schemaVersion": "1.3",
3+
"schemaVersion": "1.4",
44
"runOnRequirements": [
55
{
66
"minServerVersion": "4.0",
@@ -414,6 +414,11 @@
414414
},
415415
{
416416
"description": "commitTransaction is not retried after UnknownReplWriteConcern error",
417+
"runOnRequirements": [
418+
{
419+
"serverless": "forbid"
420+
}
421+
],
417422
"operations": [
418423
{
419424
"name": "failPoint",
@@ -546,6 +551,11 @@
546551
},
547552
{
548553
"description": "commitTransaction is not retried after UnsatisfiableWriteConcern error",
554+
"runOnRequirements": [
555+
{
556+
"serverless": "forbid"
557+
}
558+
],
549559
"operations": [
550560
{
551561
"name": "failPoint",
@@ -678,6 +688,11 @@
678688
},
679689
{
680690
"description": "commitTransaction is not retried after MaxTimeMSExpired error",
691+
"runOnRequirements": [
692+
{
693+
"serverless": "forbid"
694+
}
695+
],
681696
"operations": [
682697
{
683698
"name": "failPoint",

test/spec/transactions-convenient-api/unified/commit-writeconcernerror.yml

+10-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
description: commit-writeconcernerror
22

3-
schemaVersion: '1.3'
3+
schemaVersion: '1.4' # For `serverless` in `runOnRequirements`
44

55
runOnRequirements:
66
- minServerVersion: '4.0'
@@ -151,6 +151,9 @@ tests:
151151
outcome: *outcome
152152
-
153153
description: commitTransaction is not retried after UnknownReplWriteConcern error
154+
runOnRequirements:
155+
# Serverless sets empty `codeName` on failpoint errors. Remove once CLOUDP-280424 is fixed.
156+
- serverless: forbid
154157
operations:
155158
- name: failPoint
156159
object: testRunner
@@ -203,6 +206,9 @@ tests:
203206
outcome: *outcome
204207
-
205208
description: commitTransaction is not retried after UnsatisfiableWriteConcern error
209+
runOnRequirements:
210+
# Serverless sets empty `codeName` on failpoint errors. Remove once CLOUDP-280424 is fixed.
211+
- serverless: forbid
206212
operations:
207213
- name: failPoint
208214
object: testRunner
@@ -226,6 +232,9 @@ tests:
226232
outcome: *outcome
227233
-
228234
description: commitTransaction is not retried after MaxTimeMSExpired error
235+
runOnRequirements:
236+
# Serverless sets empty `codeName` on failpoint errors. Remove once CLOUDP-280424 is fixed.
237+
- serverless: forbid
229238
operations:
230239
- name: failPoint
231240
object: testRunner

test/spec/transactions/unified/retryable-commit.json

+5
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,11 @@
8989
"tests": [
9090
{
9191
"description": "commitTransaction fails after Interrupted",
92+
"runOnRequirements": [
93+
{
94+
"serverless": "forbid"
95+
}
96+
],
9297
"operations": [
9398
{
9499
"object": "testRunner",

test/spec/transactions/unified/retryable-commit.yml

+3
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,9 @@ initialData:
6767
tests:
6868
-
6969
description: 'commitTransaction fails after Interrupted'
70+
runOnRequirements:
71+
# Serverless sets empty `codeName` on failpoint errors. Remove once CLOUDP-280424 is fixed.
72+
- serverless: forbid
7073
operations:
7174
-
7275
object: testRunner

0 commit comments

Comments
 (0)