VS-113: Analyze POCOs that are used by LINQ or Builders at verbosity medium setting (#51)

Author: BorisDog

src/MongoDB.Analyzer/Core/Poco/PocoExpressionProcessor.cs

@@ -84,7 +84,8 @@ private static bool IsValidBsonAttribute(MongoAnalysisContext context, Attribute
     private static bool PreanalyzeClassDeclaration(MongoAnalysisContext context, INamedTypeSymbol classSymbol) =>
         context.Settings.PocoAnalysisVerbosity == PocoAnalysisVerbosity.All ||
         (classSymbol != null &&
-        (ContainsBsonAttributes(context, classSymbol) ||
-        ContainsPropertiesWithBsonAttributes(context, classSymbol) ||
-        ContainsFieldsWithBsonAttributes(context, classSymbol)));
+        (context.TypesProcessor.IsUserTypeProcessed(classSymbol) ||
+         ContainsBsonAttributes(context, classSymbol) ||
+         ContainsPropertiesWithBsonAttributes(context, classSymbol) ||
+         ContainsFieldsWithBsonAttributes(context, classSymbol)));
 }

src/MongoDB.Analyzer/Core/TypesProcessor.cs

@@ -45,11 +45,15 @@ public MemberDeclarationSyntax GetTypeSymbolToMemberDeclarationMapping(ITypeSymb
         return null;
     }
 
-    public string GetTypeSymbolToGeneratedTypeMapping(ITypeSymbol typeSymbol) => GetGeneratedTypeMapping(typeSymbol).RemappedName;
+    public bool IsUserTypeProcessed(ITypeSymbol typeSymbol) =>
+        GetGeneratedTypeMapping(typeSymbol, true).RemappedName != null;
+
+    public string GetTypeSymbolToGeneratedTypeMapping(ITypeSymbol typeSymbol) =>
+        GetGeneratedTypeMapping(typeSymbol, false).RemappedName;
 
     public string ProcessTypeSymbol(ITypeSymbol typeSymbol)
     {
-        var (remappedName, fullTypeName) = GetGeneratedTypeMapping(typeSymbol);
+        var (remappedName, fullTypeName) = GetGeneratedTypeMapping(typeSymbol, false);
         if (fullTypeName == null)
         {
             return null;
@@ -74,15 +78,15 @@ public string ProcessTypeSymbol(ITypeSymbol typeSymbol)
         return remappedName;
     }
 
-    private (string RemappedName, string FullTypeName) GetGeneratedTypeMapping(ITypeSymbol typeSymbol)
+    private (string RemappedName, string FullTypeName) GetGeneratedTypeMapping(ITypeSymbol typeSymbol, bool userOnlyTypes)
     {
         if (typeSymbol == null)
         {
             return default;
         }
 
         var fullTypeName = GetFullName(typeSymbol);
-        if (typeSymbol.IsSupportedBsonType(fullTypeName))
+        if (!userOnlyTypes && typeSymbol.IsSupportedBsonType(fullTypeName))
         {
             return (typeSymbol.Name, fullTypeName);
         }
@@ -92,7 +96,7 @@ public string ProcessTypeSymbol(ITypeSymbol typeSymbol)
             return (result.NewName, fullTypeName);
         }
 
-        if (typeSymbol.IsSupportedSystemType(fullTypeName))
+        if (!userOnlyTypes && typeSymbol.IsSupportedSystemType(fullTypeName))
         {
             return (fullTypeName, fullTypeName);
         }

tests/MongoDB.Analyzer.Tests.Common.TestCases/Poco/PocoVerbosity.cs

@@ -13,16 +13,45 @@
 // limitations under the License.
 
 using MongoDB.Bson.Serialization.Attributes;
+using MongoDB.Driver;
 
 namespace MongoDB.Analyzer.Tests.Common.TestCases.Poco
 {
     public sealed class PocoVerbosity : TestCasesBase
     {
+        [NoDiagnostics(pocoAnalysisVerbosity: PocoAnalysisVerbosity.None)]
+        public void Airline_not_used_in_expression1()
+        {
+        }
+
         [NoDiagnostics(pocoAnalysisVerbosity: PocoAnalysisVerbosity.Medium)]
-        public void Airline()
+        public void Airline_not_used_in_expression2()
+        {
+        }
+
+        [PocoJson("{ \"AirlineName\" : \"Radiant Skies Aviation\" }", PocoAnalysisVerbosity.All)]
+        public void Airline_not_used_in_expression3()
         {
         }
 
+        [NoDiagnostics(pocoAnalysisVerbosity: PocoAnalysisVerbosity.None)]
+        public void Airline_used_in_expression1()
+        {
+            _ = Builders<TestClasses.Airline_used_in_expression1>.Filter.Eq(u => u.AirlineName, "Lufthansa");
+        }
+
+        [PocoJson("{ \"AirlineName\" : \"Radiant Skies Aviation\" }", PocoAnalysisVerbosity.Medium)]
+        public void Airline_used_in_expression2()
+        {
+            _ = Builders<TestClasses.Airline_used_in_expression2>.Filter.Eq(u => u.AirlineName, "Lufthansa");
+        }
+
+        [PocoJson("{ \"AirlineName\" : \"Radiant Skies Aviation\" }", PocoAnalysisVerbosity.All)]
+        public void Airline_used_in_expression3()
+        {
+            _ = Builders<TestClasses.Airline_used_in_expression3>.Filter.Eq(u => u.AirlineName, "Lufthansa");
+        }
+
         [PocoJson("{ \"StringProperty\" : \"StringProperty_val\" }", pocoAnalysisVerbosity: PocoAnalysisVerbosity.Medium)]
         public void ClassWithBsonAttributes()
         {
@@ -65,7 +94,32 @@ public void ClassWithPropertyAndFieldAttributes2()
 
         public class TestClasses
         {
-            public class Airline
+            public class Airline_not_used_in_expression1
+            {
+                public string AirlineName { get; set; }
+            }
+
+            public class Airline_not_used_in_expression2
+            {
+                public string AirlineName { get; set; }
+            }
+
+            public class Airline_not_used_in_expression3
+            {
+                public string AirlineName { get; set; }
+            }
+
+            public class Airline_used_in_expression1
+            {
+                public string AirlineName { get; set; }
+            }
+
+            public class Airline_used_in_expression2
+            {
+                public string AirlineName { get; set; }
+            }
+
+            public class Airline_used_in_expression3
             {
                 public string AirlineName { get; set; }
             }