Skip to content

Commit 7654b17

Browse files
authored
Add return type void in FindAndModifyCommandSubscriber to prevent deprecation warnings (#2913)
Using $model::firstOrCreate(...) currently results in deprecation warnings. Can be addressed by adding `void` return type. Warnings: ``` DEPRECATED Return type of MongoDB\Laravel\Internal\FindAndModifyCommandSubscriber::commandStarted(MongoDB\Driver\Monitoring\CommandStartedEvent $event) should either be compatible with MongoDB\Driver\Monitoring\CommandSubscriber::commandStarted(MongoDB\Driver\Monitoring\CommandStartedEvent $event): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in vendor/mongodb/laravel-mongodb/src/Internal/FindAndModifyCommandSubscriber.php on line 26. DEPRECATED Return type of MongoDB\Laravel\Internal\FindAndModifyCommandSubscriber::commandSucceeded(MongoDB\Driver\Monitoring\CommandSucceededEvent $event) should either be compatible with MongoDB\Driver\Monitoring\CommandSubscriber::commandSucceeded(MongoDB\Driver\Monitoring\CommandSucceededEvent $event): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in vendor/mongodb/laravel-mongodb/src/Internal/FindAndModifyCommandSubscriber.php on line 30. DEPRECATED Return type of MongoDB\Laravel\Internal\FindAndModifyCommandSubscriber::commandFailed(MongoDB\Driver\Monitoring\CommandFailedEvent $event) should either be compatible with MongoDB\Driver\Monitoring\CommandSubscriber::commandFailed(MongoDB\Driver\Monitoring\CommandFailedEvent $event): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in vendor/mongodb/laravel-mongodb/src/Internal/FindAndModifyCommandSubscriber.php on line 22. ```
1 parent 3750253 commit 7654b17

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
# Changelog
22
All notable changes to this project will be documented in this file.
33

4+
## [4.2.2] - 2024-04-25
5+
6+
* Add return types to `FindAndModifyCommandSubscriber`, used by `firstOrCreate` by @wivaku in [#2913](https://github.com/mongodb/laravel-mongodb/pull/2913)
7+
48
## [4.2.1] - 2024-04-25
59

610
* Set timestamps when using `Model::createOrFirst()` by @GromNaN in [#2905](https://github.com/mongodb/laravel-mongodb/pull/2905)

src/Internal/FindAndModifyCommandSubscriber.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,15 +19,15 @@ final class FindAndModifyCommandSubscriber implements CommandSubscriber
1919
{
2020
public bool $created;
2121

22-
public function commandFailed(CommandFailedEvent $event)
22+
public function commandFailed(CommandFailedEvent $event): void
2323
{
2424
}
2525

26-
public function commandStarted(CommandStartedEvent $event)
26+
public function commandStarted(CommandStartedEvent $event): void
2727
{
2828
}
2929

30-
public function commandSucceeded(CommandSucceededEvent $event)
30+
public function commandSucceeded(CommandSucceededEvent $event): void
3131
{
3232
$this->created = ! $event->getReply()->lastErrorObject->updatedExisting;
3333
}

0 commit comments

Comments
 (0)