fix: enforce the HasLimit req by Explain #257
Open
+15
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ExplainQuery was adding HasLimit component with n=1 but when the query already had a HasLimit component (parsed from the Java code), this newly added component was getting ignored in the DataGripMongoDbDriver.runQuery and instead of returning an object we were returning a list, which was later causing an exception in ExplainQuery itself. I don't have a stack trace but it should be easy to reproduce by having a query with limit and letting the Index inspection run on it. The exception should be visible in debug console. This commit fixes that by replacing the existing limit if any which should be safe to do particularly for ExplainQuery.
himanshusinghs
added
the
no-title-validation
kmruiz
approved these changes
Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExplainQuery was adding HasLimit component with n=1 but when the query already had a HasLimit component (parsed from the Java code), this newly added component was getting ignored in the
DataGripMongoDbDriver.runQuery and instead of returning an object we were returning a list, which was later causing an exception in ExplainQuery itself.
I don't have a stack trace but it should be easy to reproduce by having a query with limit and letting the Index inspection run on it. The exception should be visible in debug console.
This commit fixes that by replacing the existing limit if any which should be safe to do particularly for ExplainQuery.
Description
Checklist
Open Questions