Skip to content

Commit e8f58eb

Browse files
committed
Edits
1 parent 14e4974 commit e8f58eb

File tree

7 files changed

+8
-45
lines changed

7 files changed

+8
-45
lines changed

django_mongodb_backend/checks.py

+2-5
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@
44
from django.core.checks import Tags, register
55
from django.db import connections, router
66

7-
from django_mongodb_backend.indexes import VectorSearchIndex
8-
97

108
@register(Tags.models)
119
def check_vector_search_indexes(app_configs, databases=None, **kwargs): # noqa: ARG001
@@ -21,7 +19,6 @@ def check_vector_search_indexes(app_configs, databases=None, **kwargs): # noqa:
2119
continue
2220
connection = connections[db]
2321
for model_index in model._meta.indexes:
24-
if not isinstance(model_index, VectorSearchIndex):
25-
continue
26-
errors.extend(model_index.check(model, connection))
22+
if hasattr(model_index, "check"):
23+
errors.extend(model_index.check(model, connection))
2724
return errors

django_mongodb_backend/features.py

+2
Original file line numberDiff line numberDiff line change
@@ -616,8 +616,10 @@ def is_mongodb_6_3(self):
616616
@cached_property
617617
def supports_search_indexes(self):
618618
try:
619+
# Try to execute an search indexes operation.
619620
self.connection.get_collection("__null").list_search_indexes()
620621
except OperationFailure:
622+
# Operation fails then search indexes isn't supported
621623
return False
622624
else:
623625
return True

django_mongodb_backend/fields/validators.py

-19
This file was deleted.

django_mongodb_backend/indexes.py

-1
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,6 @@ class VectorSearchIndex(SearchIndex):
147147

148148
def __init__(self, *expressions, similarities="cosine", **kwargs):
149149
super().__init__(*expressions, **kwargs)
150-
# validate the similarities types
151150
self.similarities = similarities
152151

153152
def check(self, model, connection):

tests/indexes_/models.py

+2-4
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,6 @@ class Article(models.Model):
1414
body = models.TextField()
1515
data = models.JSONField()
1616
embedded = EmbeddedModelField(Data)
17-
auto_now = models.DateTimeField(auto_now=True)
17+
created_at = models.DateTimeField(auto_now=True)
1818
title_embedded = ArrayField(models.FloatField(), size=10)
19-
description_embedded = ArrayField(models.FloatField(), size=10)
20-
number_list = ArrayField(models.FloatField())
21-
name_list = ArrayField(models.CharField(max_length=30), size=10)
19+
description_embedded = ArrayField(models.DecimalField(decimal_places=3, max_digits=10), size=10)

tests/indexes_/test_atlas_indexes.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ def test_multiple_fields(self):
4242
with connection.schema_editor() as editor:
4343
index = SearchIndex(
4444
name="recent_article_idx",
45-
fields=["headline", "number", "body", "data", "embedded", "auto_now"],
45+
fields=["headline", "number", "body", "data", "embedded", "created_at"],
4646
)
4747
editor.add_index(index=index, model=Article)
4848
index_info = connection.introspection.get_constraints(
@@ -52,7 +52,7 @@ def test_multiple_fields(self):
5252
expected_options = {
5353
"dynamic": False,
5454
"fields": {
55-
"auto_now": {"type": "date"},
55+
"created_at": {"type": "date"},
5656
"body": {
5757
"indexOptions": "offsets",
5858
"norms": "include",

tests/validators_/tests.py

-14
This file was deleted.

0 commit comments

Comments
 (0)