Skip to content

Commit 9ec493f

Browse files
committed
reclassify expected failures as skips
Updating the affected models to use ObjectIdField breaks other tests.
1 parent 1df75fc commit 9ec493f

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

django_mongodb/features.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -77,10 +77,6 @@ class DatabaseFeatures(BaseDatabaseFeatures):
7777
# Connection creation doesn't follow the usual Django API.
7878
"backends.tests.ThreadTests.test_pass_connection_between_threads",
7979
"backends.tests.ThreadTests.test_default_connection_thread_local",
80-
# ObjectId type mismatch in a subquery:
81-
# https://github.com/mongodb-labs/django-mongodb/issues/161
82-
"queries.tests.RelatedLookupTypeTests.test_values_queryset_lookup",
83-
"queries.tests.ValuesSubqueryTests.test_values_in_subquery",
8480
# Object of type ObjectId is not JSON serializable.
8581
"auth_tests.test_views.LoginTest.test_login_session_without_hash_session_key",
8682
# GenericRelation.value_to_string() assumes integer pk.
@@ -225,6 +221,8 @@ def django_test_expected_failures(self):
225221
"expressions.tests.BasicExpressionsTests.test_nested_subquery_outer_ref_with_autofield",
226222
"model_fields.test_foreignkey.ForeignKeyTests.test_to_python",
227223
"queries.test_qs_combinators.QuerySetSetOperationTests.test_order_raises_on_non_selected_column",
224+
"queries.tests.RelatedLookupTypeTests.test_values_queryset_lookup",
225+
"queries.tests.ValuesSubqueryTests.test_values_in_subquery",
228226
},
229227
"Cannot use QuerySet.delete() when querying across multiple collections on MongoDB.": {
230228
"admin_changelist.tests.ChangeListTests.test_distinct_for_many_to_many_at_second_level_in_search_fields",

0 commit comments

Comments
 (0)