CLOUDP-309672: bump to go1.24 (#66)

* bump to go1.24

* bump golangci-lint

* fix linter errors

Author: s-urbaniak

.github/workflows/code-health.yml

@@ -23,9 +23,8 @@ jobs:
           go-version-file: 'go.mod'
           cache: false # see https://github.com/golangci/golangci-lint-action/issues/807
       - name: golangci-lint
-        uses: golangci/golangci-lint-action@v6.1.1
+        uses: golangci/golangci-lint-action@v7.0.0
         with:
-          version: v1.61.0
           args: --timeout 3m0s
   licensecheck:
     name: licensecheck

CONTRIBUTING.md

@@ -47,7 +47,7 @@ To make the contribution process as seamless as possible, we ask for the followi
 #### Prerequisite Tools
 
 - [Git](https://git-scm.com/)
-- [Go (at least Go 1.23.1)](https://golang.org/dl/)
+- [Go (at least Go 1.24)](https://golang.org/dl/)
 
 #### Environment
 

build/ci/evergreen.yml

@@ -21,8 +21,8 @@ include:
 
 variables:
   - &go_linux_version
-      go_root: "/opt/golang/go1.23"
-      go_bin: "/opt/golang/go1.23/bin"
+      go_root: "/opt/golang/go1.24"
+      go_bin: "/opt/golang/go1.24/bin"
       go_base_path: ""
   - &go_env
       XDG_CONFIG_HOME: ${go_base_path}${workdir}

build/ci/release.yml

@@ -14,8 +14,8 @@
 
 variables:
   - &go_linux_version
-      go_root: "/opt/golang/go1.23"
-      go_bin: "/opt/golang/go1.23/bin"
+      go_root: "/opt/golang/go1.24"
+      go_bin: "/opt/golang/go1.24/bin"
       go_base_path: ""
   - &go_env
       XDG_CONFIG_HOME: ${go_base_path}${workdir}

go.mod

@@ -1,6 +1,6 @@
 module github.com/mongodb/atlas-cli-plugin-kubernetes
 
-go 1.23.6
+go 1.24
 
 require (
 	cloud.google.com/go/compute v1.34.1

internal/cli/kubernetes/dryrun/dryrun.go

@@ -112,7 +112,7 @@ func Builder() *cobra.Command {
 		Short:   "Deploy and run Atlas Kubernetes Operator in dry-run mode",
 		Long:    `This command deploys the Atlas Kubernetes operator with the DryRun mode.`,
 		PreRunE: func(_ *cobra.Command, _ []string) error {
-			return opts.OrgOpts.PreRunE(
+			return opts.PreRunE(
 				opts.ValidateTargetNamespace,
 				opts.ValidateOperatorVersion,
 			)

internal/cli/kubernetes/kubernetes.go

@@ -52,7 +52,7 @@ func Builder() *cobra.Command {
 				return fmt.Errorf("failed to load Atlas CLI configuration: %v", err)
 			}
 			if err := coreConfig.InitProfile(profile); err != nil {
-				return fmt.Errorf("Failed to initialise Atlas CLI profile: %v", err)
+				return fmt.Errorf("failed to initialise Atlas CLI profile: %w", err)
 			}
 
 			telemetry.TrackPluginCommand(cmd, args)

internal/kubernetes/operator/crds/provider.go

@@ -43,6 +43,7 @@ func (p EmbeddedAtlasCRDProvider) GetAtlasOperatorResource(resourceName, version
 	if err != nil {
 		return nil, fmt.Errorf("failed to open embeddedPath path %q: %w", embeddedPath, err)
 	}
+	//nolint:errcheck
 	defer f.Close()
 
 	data, err := io.ReadAll(f)

internal/kubernetes/operator/features/embeded_test.go

@@ -28,7 +28,6 @@ import (
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
 	apiextensionsv1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1"
-	v1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1"
 	"sigs.k8s.io/yaml"
 )
 
@@ -61,7 +60,7 @@ func diffResource(t *testing.T, httpClient *http.Client, provider crds.AtlasOper
 	return !reflect.DeepEqual(localCRD, remoteCRD)
 }
 
-func getGitHubCRD(httpClient *http.Client, resource, version string) (*v1.CustomResourceDefinition, error) {
+func getGitHubCRD(httpClient *http.Client, resource, version string) (*apiextensionsv1.CustomResourceDefinition, error) {
 	ctx, cancelF := context.WithTimeout(context.Background(), requestTimeout)
 	defer cancelF()
 
@@ -75,6 +74,7 @@ func getGitHubCRD(httpClient *http.Client, resource, version string) (*v1.Custom
 	if err != nil {
 		return nil, fmt.Errorf("failed to GET %s: %w", url, err)
 	}
+	//nolint:errcheck
 	defer resp.Body.Close()
 
 	data, err := io.ReadAll(resp.Body)

internal/telemetry/tracker.go

@@ -97,6 +97,7 @@ func (t *pluginTracker) read() ([]Event, error) {
 		if err != nil {
 			return events, err
 		}
+		//nolint:errcheck
 		defer file.Close()
 		decoder := json.NewDecoder(file)
 		for decoder.More() {
@@ -117,6 +118,7 @@ func (t *pluginTracker) save(event Event) error {
 		return err
 	}
 
+	//nolint:errcheck
 	defer file.Close()
 	data, err := json.Marshal(event)
 	if err != nil {