PYTHON-5179 Fix memory leak in bson_str_to_json (#64)

blink1073 · web-flow · commit 2e6aa7aa756a · 2025-03-03T13:02:24.000-06:00
* PYTHON-5179 Fix memory leak in bson_str_to_json

* update changelog

* address review
diff --git a/CHANGELOG.rst b/CHANGELOG.rst
@@ -3,7 +3,8 @@ Changelog
 
 0.6.0 (unreleased)
 ``````````````````
-Drop support for Python 3.8.
+- Drop support for Python 3.8.
+- Fix memory leak in ``dump`` and ``dumps`` when an invalid ``mode`` is provided.
 
 0.5.0
 `````
diff --git a/bsonjs/bsonjs.c b/bsonjs/bsonjs.c
@@ -50,6 +50,7 @@ int mode)
         PyErr_SetString(PyExc_ValueError, "The value of mode must be one of: "
                                           "bsonjs.RELAXED, bsonjs.LEGACY, "
                                           "or bsonjs.CANONICAL.");
+        bson_reader_destroy(reader);
         return NULL;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -50,6 +50,7 @@ int mode)`
`50`	`50`	`PyErr_SetString(PyExc_ValueError, "The value of mode must be one of: "`
`51`	`51`	`"bsonjs.RELAXED, bsonjs.LEGACY, "`
`52`	`52`	`"or bsonjs.CANONICAL.");`
	`53`	`+ bson_reader_destroy(reader);`
`53`	`54`	`return NULL;`
`54`	`55`	`}`
`55`	`56`