Merge branch 'main' of github.com:mongodb-js/compass into gagik/headless-context-menu

Author: gagik

.evergreen/print-compass-env.sh

@@ -43,8 +43,8 @@ if [[ "${EVERGREEN_PROJECT}" == "10gen-compass-main" ]]; then
         month=$(escapeLeadingZero "${ts[1]}")
         day=$(escapeLeadingZero "${ts[2]}")
         hour=$(escapeLeadingZero "${ts[3]}")
-        minute="${ts[4]}"
-        second="${ts[5]}"
+        minute=$(escapeLeadingZero "${ts[4]}")
+        second=$(escapeLeadingZero "${ts[5]}")
         export DEV_VERSION_IDENTIFIER="${year}.${month}.${day}-dev.${hour}${minute}${second}"
     fi
 fi

.github/CODEOWNERS

@@ -0,0 +1 @@
+*          @mongodb-js/compass-developers

.github/dependabot.yml renamed to .github/_dependabot.yml

@@ -46,7 +46,10 @@ jobs:
         run: echo "[Evergreen Task](${{ github.event.inputs.evergreen_task_url }})" >> $GITHUB_STEP_SUMMARY
   test:
     name: ${{ matrix.package }} test ${{ matrix.test }} (${{ matrix.hadron-distribution }})
-    timeout-minutes: 30
+    # Windows specifically takes A TON of time to bootstrap itself before being
+    # able to run tests, so we're setting the timeout pretty high to account for
+    # that
+    timeout-minutes: 60
     strategy:
       fail-fast: false
       matrix:
@@ -174,7 +177,7 @@ jobs:
     runs-on: ${{ matrix.runs-on }}
     container: ${{ matrix.container }}
     env:
-      DEBUG: compass:smoketests:*
+      DEBUG: compass:smoketests:*,compass-e2e-tests:*
     steps:
       - name: Checkout
         uses: actions/checkout@v2

.github/workflows/test-installers.yml

@@ -38,7 +38,10 @@ jobs:
 
       - name: Bump eslint
         run: |
-          npm i --save eslint@8 -w @mongodb-js/eslint-config-compass
+          npm i --save --workspace @mongodb-js/eslint-config-compass \
+              eslint@8 \
+              @typescript-eslint/eslint-plugin@latest \
+              @typescript-eslint/parser@latest
 
       - name: Create Pull Request
         uses: peter-evans/create-pull-request@5e914681df9dc83aa4e4905692ca88beb2f9e91f # 7.0.5

.github/workflows/update-eslint.yaml

@@ -104,3 +104,4 @@ Dylan Richardson <[email protected]>
 Ruby Dong <[email protected]>
 Neal Beeken <[email protected]>
 Walter Tan <[email protected]>
+Raymond Lo <[email protected]>

AUTHORS

@@ -3,6 +3,7 @@
 const path = require('path');
 const shared = require('@mongodb-js/eslint-config-devtools');
 const common = require('@mongodb-js/eslint-config-devtools/common');
+const chaiFriendly = require('eslint-plugin-chai-friendly');
 
 const extraTsRules = {
   // Newly converted plugins use `any` quite a lot, we can't enable the rule,
@@ -15,6 +16,18 @@ const extraTsRules = {
     'error',
     { fixMixedExportsWithInlineTypeSpecifier: false },
   ],
+  // We use chai outside of tests, hence applying these rules to all ts files
+  ...chaiFriendly.configs.recommended.rules,
+  '@typescript-eslint/prefer-promise-reject-errors': 'off',
+  '@typescript-eslint/only-throw-error': 'off',
+
+  // TODO: a lot new hits with latest typescript-eslint, we should gradually
+  // clean those out and re-enable the rules
+  '@typescript-eslint/no-explicit-any': 'warn',
+  '@typescript-eslint/no-base-to-string': 'warn',
+  '@typescript-eslint/unbound-method': 'warn',
+  '@typescript-eslint/no-duplicate-type-constituents': 'warn',
+  '@typescript-eslint/no-unsafe-declaration-merging': 'warn',
 };
 
 const tsRules = {
@@ -50,7 +63,7 @@ const commonTestOverrides = {
     {
       patterns: [
         {
-          group: '@testing-library/*',
+          group: ['@testing-library/*'],
           message: 'Use @mongodb-js/testing-library-compass instead',
           allowTypeImports: false,
         },
@@ -84,7 +97,7 @@ const testTsOverrides = {
 };
 
 module.exports = {
-  plugins: [...shared.plugins, '@mongodb-js/compass'],
+  plugins: [...shared.plugins, '@mongodb-js/compass', 'chai-friendly'],
   rules: {
     ...shared.rules,
     '@mongodb-js/compass/no-leafygreen-outside-compass-components': 'error',

THIRD-PARTY-NOTICES.md

@@ -1,6 +1,6 @@
 {
   "name": "@mongodb-js/eslint-config-compass",
-  "version": "1.3.9",
+  "version": "1.3.10",
   "description": "Shared Compass eslint configuration",
   "license": "SSPL",
   "main": "index.js",
@@ -18,10 +18,11 @@
     "@babel/eslint-parser": "^7.14.3",
     "@mongodb-js/eslint-config-devtools": "^0.9.9",
     "@mongodb-js/eslint-plugin-compass": "^1.2.9",
-    "@typescript-eslint/eslint-plugin": "^5.59.0",
-    "@typescript-eslint/parser": "^5.59.0",
+    "@typescript-eslint/eslint-plugin": "^8.34.0",
+    "@typescript-eslint/parser": "^8.34.0",
     "eslint": "^8.57.1",
     "eslint-config-prettier": "^8.3.0",
+    "eslint-plugin-chai-friendly": "^1.1.0",
     "eslint-plugin-filename-rules": "^1.2.0",
     "eslint-plugin-jsx-a11y": "^6.10.2",
     "eslint-plugin-mocha": "^8.0.0",

configs/eslint-config-compass/index.js

@@ -10,28 +10,51 @@ function restrictedProviderImport(servicePkg) {
   };
 }
 
+// node built-ins with meaningful polyfills in web environment
+const allowedNodeJSBuiltinModules = ['assert', 'stream', 'events'];
+
 module.exports = {
   ...baseConfig,
   rules: {
     ...baseConfig.rules,
     'no-restricted-imports': 'off',
     '@typescript-eslint/no-restricted-imports': [
       'error',
-      restrictedProviderImport('@mongodb-js/compass-logging'),
-      restrictedProviderImport('@mongodb-js/compass-telemetry'),
-      restrictedProviderImport('@mongodb-js/compass-app-stores'),
-      restrictedProviderImport('@mongodb-js/my-queries-storage'),
-      restrictedProviderImport('@mongodb-js/atlas-service'),
-      restrictedProviderImport('compass-preferences-model'),
-      {
-        paths: require('module').builtinModules,
-        message: 'Using Node.js built-in modules in plugins is not allowed.',
-        allowTypeImports: false,
-      },
       {
-        paths: ['electron', '@electron/remote'],
-        message: 'Using electron modules in plugins is not allowed.',
-        allowTypeImports: false,
+        paths: [
+          restrictedProviderImport('@mongodb-js/compass-logging'),
+          restrictedProviderImport('@mongodb-js/compass-telemetry'),
+          restrictedProviderImport('@mongodb-js/compass-app-stores'),
+          restrictedProviderImport('@mongodb-js/my-queries-storage'),
+          restrictedProviderImport('@mongodb-js/atlas-service'),
+          restrictedProviderImport('compass-preferences-model'),
+          ...require('module')
+            .builtinModules.filter((module) => {
+              return (
+                !module.startsWith('_') &&
+                !allowedNodeJSBuiltinModules.includes(module)
+              );
+            })
+            .flatMap((name) => {
+              const config = {
+                message:
+                  'Using Node.js built-in modules in plugins is not allowed.',
+                allowTypeImports: true,
+              };
+
+              return [
+                { name, ...config },
+                { name: `node:${name}`, ...config },
+              ];
+            }),
+          ...['electron', '@electron/remote'].map((name) => {
+            return {
+              name,
+              message: 'Using electron modules in plugins is not allowed.',
+              allowTypeImports: false,
+            };
+          }),
+        ],
       },
     ],
   },

configs/eslint-config-compass/package.json

@@ -11,7 +11,7 @@
     "email": "[email protected]"
   },
   "homepage": "https://github.com/mongodb-js/compass",
-  "version": "1.3.1",
+  "version": "1.3.2",
   "repository": {
     "type": "git",
     "url": "https://github.com/mongodb-js/compass.git"
@@ -45,7 +45,7 @@
     "reformat": "npm run eslint . -- --fix && npm run prettier -- --write ."
   },
   "devDependencies": {
-    "@mongodb-js/eslint-config-compass": "^1.3.9",
+    "@mongodb-js/eslint-config-compass": "^1.3.10",
     "@mongodb-js/mocha-config-compass": "^1.6.8",
     "@mongodb-js/prettier-config-compass": "^1.2.8",
     "@mongodb-js/tsconfig-compass": "^1.2.8",

configs/eslint-config-compass/plugin.js

@@ -13,7 +13,7 @@
     "email": "[email protected]"
   },
   "homepage": "https://github.com/mongodb-js/compass",
-  "version": "1.6.10",
+  "version": "1.8.0",
   "repository": {
     "type": "git",
     "url": "https://github.com/mongodb-js/compass.git"
@@ -45,7 +45,7 @@
     "reformat": "npm run eslint . -- --fix && npm run prettier -- --write ."
   },
   "devDependencies": {
-    "@mongodb-js/eslint-config-compass": "^1.3.9",
+    "@mongodb-js/eslint-config-compass": "^1.3.10",
     "@mongodb-js/prettier-config-compass": "^1.2.8",
     "@mongodb-js/tsconfig-compass": "^1.2.8",
     "@types/cli-progress": "^3.9.2",
@@ -66,12 +66,12 @@
     "@pmmmwh/react-refresh-webpack-plugin": "^0.5.15",
     "babel-loader": "^8.2.5",
     "babel-plugin-istanbul": "^5.2.0",
-    "browserslist": "^4.24.4",
+    "browserslist": "^4.25.0",
     "chalk": "^4.1.2",
     "cli-progress": "^3.9.1",
     "core-js": "^3.17.3",
     "css-loader": "^4.3.0",
-    "electron": "^32.3.3",
+    "electron": "^36.4.0",
     "html-webpack-plugin": "^5.6.0",
     "less": "^3.13.1",
     "less-loader": "^10.0.1",

configs/testing-library-compass/package.json

@@ -147,6 +147,17 @@ export function createElectronMainConfig(
         sharedObjectLoader(opts),
         sourceLoader(opts),
       ],
+      parser: {
+        javascript: {
+          // Webpack compile time check for imports matching exports is too strict
+          // in cases where the code expects some name export to be optional
+          // (webpack will break the build if it fails to statically see the
+          // matching export) this is why we switch the check to just warn. If
+          // this ever hides a real case where a missing import is being used, it
+          // will definitely break in runtime anyway
+          importExportsPresence: 'warn' as const,
+        },
+      },
     },
     node: false as const,
     externals: toCommonJsExternal(sharedExternals),
@@ -218,6 +229,11 @@ export function createElectronRendererConfig(
         sharedObjectLoader(opts),
         sourceLoader(opts),
       ],
+      parser: {
+        javascript: {
+          importExportsPresence: 'warn' as const,
+        },
+      },
     },
     plugins: [
       ...entriesToHtml(entries),
@@ -301,7 +317,7 @@ export function createElectronRendererConfig(
 export function createWebConfig(args: Partial<ConfigArgs>): WebpackConfig {
   const opts = webpackArgsWithDefaults(args, { target: 'web' });
 
-  // eslint-disable-next-line @typescript-eslint/no-var-requires
+  // eslint-disable-next-line @typescript-eslint/no-require-imports
   const { peerDependencies } = require(path.join(opts.cwd, 'package.json')) as {
     peerDependencies: Record<string, string>;
   };
@@ -338,6 +354,11 @@ export function createWebConfig(args: Partial<ConfigArgs>): WebpackConfig {
         assetsLoader(opts),
         sourceLoader(opts),
       ],
+      parser: {
+        javascript: {
+          importExportsPresence: 'warn' as const,
+        },
+      },
     },
     // This follows current Compass plugin behavior and is here more or less to
     // keep compat for the external plugin users

configs/webpack-config-compass/package.json

@@ -7,7 +7,7 @@ import { isServe } from './args';
 import chalk from 'chalk';
 
 function isLatestBrowserslist() {
-  // eslint-disable-next-line @typescript-eslint/no-var-requires
+  // eslint-disable-next-line @typescript-eslint/no-require-imports
   const browserslistVersion = require('browserslist/package.json').version;
   const command = `npm view browserslist version --json`;
   const latestBrowserslistVersion = JSON.parse(
@@ -18,7 +18,7 @@ function isLatestBrowserslist() {
 }
 
 const electronVersion = (() => {
-  // eslint-disable-next-line @typescript-eslint/no-var-requires
+  // eslint-disable-next-line @typescript-eslint/no-require-imports
   const [maj, min] = require('electron/package.json').version.split(
     '.'
   ) as string[];

configs/webpack-config-compass/src/index.ts

@@ -38,7 +38,7 @@ export function entriesToHtml(
           fs.statSync(maybeTemplatePath);
           template = maybeTemplatePath;
           break;
-        } catch (e) {
+        } catch {
           // ignore and use default template, electron renderer entry will need
           // at least some kind of html page provided one way or the other
         }
@@ -62,7 +62,7 @@ export function camelCase(str: string): string {
 }
 
 export function getLibraryNameFromCwd(cwd: string): string {
-  // eslint-disable-next-line @typescript-eslint/no-var-requires
+  // eslint-disable-next-line @typescript-eslint/no-require-imports
   const { name, productName } = require(path.join(cwd, 'package.json')) as {
     name: string;
     productName: string;