Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Program crashes when show container log #118

Open
Ringeltier opened this issue Aug 26, 2019 · 4 comments
Open

Program crashes when show container log #118

Ringeltier opened this issue Aug 26, 2019 · 4 comments
Labels

Comments

@Ringeltier
Copy link

Hello everyone.
When a container is started with another log driver eg. fluentd the container will not have a json log. In this case the dry program will crash because it can not open a file which not exists.

You have to implement a check for the log driver of each container to prevent this case.

Sincerely,
Stefan

@moncho
Copy link
Owner

moncho commented Aug 26, 2019

Thanks for reporting!

@bypper
Copy link

bypper commented Feb 6, 2025

If you try to fetch logs in a container without logs (runned with logging driver="none"), Container is freezed.

@moncho
Copy link
Owner

moncho commented Feb 7, 2025

@bypper I have not been able to reproduce it. I tried fetching the logs of a container run with log-driver none (docker run -it --log-driver none alpine ash) and dry shows an error.

@bypper
Copy link

bypper commented Feb 7, 2025

Hi @moncho,
This is my command:

docker compose -f 0-compose-global.yml run --name midry --rm dry; docker image rm moncho/dry

and this is the compose block related:

  dry:
    container_name: midry
    image: moncho/dry
    volumes:
      - /var/run/docker.sock:/var/run/docker.sock
    environment:
      TZ: Europe/Madrid
    networks:
      - albred
      - albredpriv
    deploy:
      resources:
        limits:
          cpus: '0.3'
    # Disable logging for this service...
    logging:
      driver: "none"

Actually, container is not freeze, I can see is up, but the foreground screen yes, and I cannot work with it already, after select "Fetch logs" option of menu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants